From 5d97a350a0d51e9172273e06e7dc48b0853971fd Mon Sep 17 00:00:00 2001 From: JT Date: Sat, 11 Nov 2023 15:40:32 -0800 Subject: [PATCH] Fixed test and added changedlog --- .changelog/34362.txt | 3 +++ internal/service/cognitoidp/user_pool_client_test.go | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) create mode 100644 .changelog/34362.txt diff --git a/.changelog/34362.txt b/.changelog/34362.txt new file mode 100644 index 000000000000..6a916179249f --- /dev/null +++ b/.changelog/34362.txt @@ -0,0 +1,3 @@ +```release-note:bug +resource/aws_cognito_user_pool_client: Added default values to access_token_validity, id_token_validity, and refresh_token_validity +``` diff --git a/internal/service/cognitoidp/user_pool_client_test.go b/internal/service/cognitoidp/user_pool_client_test.go index 8ab1b46bec7b..9c94ec91b7e0 100644 --- a/internal/service/cognitoidp/user_pool_client_test.go +++ b/internal/service/cognitoidp/user_pool_client_test.go @@ -38,7 +38,7 @@ func TestAccCognitoIDPUserPoolClient_basic(t *testing.T) { Check: resource.ComposeAggregateTestCheckFunc( testAccCheckUserPoolClientExists(ctx, resourceName, &client), resource.TestCheckResourceAttr(resourceName, "name", rName), - resource.TestCheckResourceAttr(resourceName, "access_token_validity", "0"), + resource.TestCheckResourceAttr(resourceName, "access_token_validity", "1"), resource.TestCheckResourceAttr(resourceName, "allowed_oauth_flows.#", "0"), resource.TestCheckResourceAttr(resourceName, "allowed_oauth_flows_user_pool_client", "false"), resource.TestCheckResourceAttr(resourceName, "allowed_oauth_scopes.#", "0"), @@ -52,7 +52,7 @@ func TestAccCognitoIDPUserPoolClient_basic(t *testing.T) { resource.TestCheckResourceAttr(resourceName, "explicit_auth_flows.#", "1"), resource.TestCheckTypeSetElemAttr(resourceName, "explicit_auth_flows.*", "ADMIN_NO_SRP_AUTH"), resource.TestCheckNoResourceAttr(resourceName, "generate_secret"), - resource.TestCheckResourceAttr(resourceName, "id_token_validity", "0"), + resource.TestCheckResourceAttr(resourceName, "id_token_validity", "1"), resource.TestCheckResourceAttr(resourceName, "logout_urls.#", "0"), resource.TestCheckResourceAttr(resourceName, "prevent_user_existence_errors", ""), resource.TestCheckResourceAttr(resourceName, "read_attributes.#", "0"),