-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ECS deployment circuit breakers #16499
Comments
I'm considering using this feature in our automated pipelines, and was wondering how will this be implemented in terraform:
|
when this feature can terraform support? |
Let me see if I can implement it. It seems the current aws-sdk-go already supports |
I've implemented it so please upvote the PR for a faster review! 🙏 |
waiting for this feature |
This has been released in version 3.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Description
AWS has announced ECS deployment circuit breakers that can automatically roll back a failed deployment: https://aws.amazon.com/blogs/containers/announcing-amazon-ecs-deployment-circuit-breaker/
New or Affected Resource(s)
Potential Terraform Configuration
I'm not a massive fan of that API layout and would love it to be as simple as
enable_deployment_circuit_breaker = true
as a top level thing but I think the general pattern here is to have Terraform follow the AWS API and then people can abstract that behind modules if that works for them. That way if the API changes it doesn't cause breaking changes in the provider to support the new functionality.References
The text was updated successfully, but these errors were encountered: