Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech debt: Migrateqldb resources to AWS SDK for Go v2 #32345

Merged
merged 12 commits into from
Jul 3, 2023

Conversation

ewbankkit
Copy link
Contributor

Description

Ibid.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccQLDB' PKG=qldb ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/qldb/... -v -count 1 -parallel 2  -run=TestAccQLDB -timeout 180m
=== RUN   TestAccQLDBLedgerDataSource_basic
=== PAUSE TestAccQLDBLedgerDataSource_basic
=== RUN   TestAccQLDBLedger_basic
=== PAUSE TestAccQLDBLedger_basic
=== RUN   TestAccQLDBLedger_disappears
=== PAUSE TestAccQLDBLedger_disappears
=== RUN   TestAccQLDBLedger_nameGenerated
=== PAUSE TestAccQLDBLedger_nameGenerated
=== RUN   TestAccQLDBLedger_update
=== PAUSE TestAccQLDBLedger_update
=== RUN   TestAccQLDBLedger_kmsKey
=== PAUSE TestAccQLDBLedger_kmsKey
=== RUN   TestAccQLDBLedger_tags
=== PAUSE TestAccQLDBLedger_tags
=== RUN   TestAccQLDBStream_basic
=== PAUSE TestAccQLDBStream_basic
=== RUN   TestAccQLDBStream_disappears
=== PAUSE TestAccQLDBStream_disappears
=== RUN   TestAccQLDBStream_tags
=== PAUSE TestAccQLDBStream_tags
=== RUN   TestAccQLDBStream_withEndTime
=== PAUSE TestAccQLDBStream_withEndTime
=== CONT  TestAccQLDBLedgerDataSource_basic
=== CONT  TestAccQLDBLedger_tags
--- PASS: TestAccQLDBLedger_tags (353.54s)
=== CONT  TestAccQLDBStream_tags
--- PASS: TestAccQLDBLedgerDataSource_basic (360.53s)
=== CONT  TestAccQLDBStream_withEndTime
--- PASS: TestAccQLDBStream_withEndTime (326.34s)
=== CONT  TestAccQLDBStream_disappears
--- PASS: TestAccQLDBStream_tags (486.99s)
=== CONT  TestAccQLDBStream_basic
--- PASS: TestAccQLDBStream_disappears (358.00s)
=== CONT  TestAccQLDBLedger_nameGenerated
--- PASS: TestAccQLDBStream_basic (348.57s)
=== CONT  TestAccQLDBLedger_update
--- PASS: TestAccQLDBLedger_nameGenerated (328.04s)
=== CONT  TestAccQLDBLedger_disappears
--- PASS: TestAccQLDBLedger_update (352.20s)
=== CONT  TestAccQLDBLedger_basic
--- PASS: TestAccQLDBLedger_disappears (301.45s)
=== CONT  TestAccQLDBLedger_kmsKey
--- PASS: TestAccQLDBLedger_basic (276.97s)
--- PASS: TestAccQLDBLedger_kmsKey (327.96s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/qldb	2008.017s
% make sweep SWEEPARGS=-sweep-run=aws_qldb_ledger
# make sweep SWEEPARGS=-sweep-run=aws_example_thing
# set SWEEPARGS=-sweep-allow-failures to continue after first failure
WARNING: This will destroy infrastructure. Use only in development accounts.
go test ./internal/sweep -v -tags=sweep -sweep=us-west-2,us-east-1,us-east-2 -sweep-run=aws_qldb_ledger -timeout 60m
2023/06/30 17:47:54 [DEBUG] Running Sweepers for region (us-west-2):
2023/06/30 17:47:54 [DEBUG] Sweeper (aws_qldb_ledger) has dependency (aws_qldb_stream), running..
2023/06/30 17:47:54 [DEBUG] Running Sweeper (aws_qldb_stream) in region (us-west-2)
2023/06/30 17:47:54 [DEBUG] Completed Sweeper (aws_qldb_stream) in region (us-west-2) in 824.355582ms
2023/06/30 17:47:54 [DEBUG] Running Sweeper (aws_qldb_ledger) in region (us-west-2)
2023/06/30 17:47:55 [DEBUG] Completed Sweeper (aws_qldb_ledger) in region (us-west-2) in 254.473685ms
2023/06/30 17:47:55 [DEBUG] Sweeper (aws_qldb_stream) already ran in region (us-west-2)
2023/06/30 17:47:55 Completed Sweepers for region (us-west-2) in 1.079129436s
2023/06/30 17:47:55 Sweeper Tests for region (us-west-2) ran successfully:
	- aws_qldb_stream
	- aws_qldb_ledger
2023/06/30 17:47:55 [DEBUG] Running Sweepers for region (us-east-1):
2023/06/30 17:47:55 [DEBUG] Sweeper (aws_qldb_ledger) has dependency (aws_qldb_stream), running..
2023/06/30 17:47:55 [DEBUG] Running Sweeper (aws_qldb_stream) in region (us-east-1)
2023/06/30 17:47:55 [DEBUG] Completed Sweeper (aws_qldb_stream) in region (us-east-1) in 540.03341ms
2023/06/30 17:47:55 [DEBUG] Running Sweeper (aws_qldb_ledger) in region (us-east-1)
2023/06/30 17:47:55 [DEBUG] Completed Sweeper (aws_qldb_ledger) in region (us-east-1) in 85.779903ms
2023/06/30 17:47:55 [DEBUG] Sweeper (aws_qldb_stream) already ran in region (us-east-1)
2023/06/30 17:47:55 Completed Sweepers for region (us-east-1) in 625.933558ms
2023/06/30 17:47:55 Sweeper Tests for region (us-east-1) ran successfully:
	- aws_qldb_stream
	- aws_qldb_ledger
2023/06/30 17:47:55 [DEBUG] Running Sweepers for region (us-east-2):
2023/06/30 17:47:55 [DEBUG] Sweeper (aws_qldb_ledger) has dependency (aws_qldb_stream), running..
2023/06/30 17:47:55 [DEBUG] Running Sweeper (aws_qldb_stream) in region (us-east-2)
2023/06/30 17:47:56 [DEBUG] Completed Sweeper (aws_qldb_stream) in region (us-east-2) in 488.409682ms
2023/06/30 17:47:56 [DEBUG] Running Sweeper (aws_qldb_ledger) in region (us-east-2)
2023/06/30 17:47:56 [DEBUG] Completed Sweeper (aws_qldb_ledger) in region (us-east-2) in 143.006109ms
2023/06/30 17:47:56 [DEBUG] Sweeper (aws_qldb_stream) already ran in region (us-east-2)
2023/06/30 17:47:56 Completed Sweepers for region (us-east-2) in 631.540509ms
2023/06/30 17:47:56 Sweeper Tests for region (us-east-2) ran successfully:
	- aws_qldb_stream
	- aws_qldb_ledger
ok  	github.com/hashicorp/terraform-provider-aws/internal/sweep	8.056s

@github-actions
Copy link

github-actions bot commented Jul 3, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/qldb Issues and PRs that pertain to the qldb service. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. labels Jul 3, 2023
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Jul 3, 2023
@ewbankkit ewbankkit added technical-debt Addresses areas of the codebase that need refactoring or redesign. timeouts Pertains to timeout increases. labels Jul 3, 2023
@ewbankkit ewbankkit merged commit 0af3a55 into main Jul 3, 2023
71 checks passed
@ewbankkit ewbankkit deleted the td-migrate-qldb-to-aws-sdk-v2 branch July 3, 2023 16:21
@github-actions github-actions bot added this to the v5.7.0 milestone Jul 3, 2023
github-actions bot pushed a commit that referenced this pull request Jul 3, 2023
@github-actions
Copy link

github-actions bot commented Jul 7, 2023

This functionality has been released in v5.7.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Aug 7, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2023
@justinretzolk justinretzolk added the aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. label Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/qldb Issues and PRs that pertain to the qldb service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. timeouts Pertains to timeout increases.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants