`aws_ebs_snapshot_import`: init resource #16373

grahamc · 2020-11-23T14:24:05Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

* **New Resource:** aws_ebs_snapshot_import  (#16373)

Output from acceptance testing:

$ time make fmt testacc TESTARGS='-run=TestAccAWSEBSSnapshotImport'
==> Fixing source code with gofmt...
gofmt -s -w ./aws ./awsproviderlint/helper ./awsproviderlint/main.go ./awsproviderlint/passes
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEBSSnapshotImport -timeout 120m
=== RUN   TestAccAWSEBSSnapshotImport_basic
=== PAUSE TestAccAWSEBSSnapshotImport_basic
=== CONT  TestAccAWSEBSSnapshotImport_basic
--- PASS: TestAccAWSEBSSnapshotImport_basic (625.66s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	25.694s

real	12m33.506s
user	2m43.535s
sys	2m7.373s

I don't feel incredibly comfortable that the code I wrote is good or totally right, but I gave it my best. I'm not much of a Go programmer, and started with the ebs_snapshot resource. Note I didn't add support for importing, because it seems the data around the import parameters are "Disappeared" once the import task completes.

My use case here is combining aws_ebs_snapshot_import with aws_ami and aws_ami_copy to upload, register, and distribute AMIs to a variety of regions. I use Terraform to support the pruning of images over time.

grahamc · 2020-11-23T14:25:30Z

aws/resource_aws_ebs_snapshot_import_test.go

This is a bit funny probably, but to test importing a disk image we need a disk image to import. The image on disk, base64'd, is about 3400 bytes long. Compressing, then base64'ing is much shorter, with the trade-off that we need to decompress and unbase64 on the fly for the test.

github-actions

Welcome @grahamc 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

aws/resource_aws_ebs_snapshot_import.go

grahamc · 2021-01-11T22:17:23Z

Just rebased this on top of master, and with it I added tags to the test case after discovering the previous revision of this PR didn't correctly tag the snapshot.

grahamc · 2021-03-02T23:55:05Z

Rebased and re-ran the tests.

m4h3 · 2021-04-23T16:05:49Z

can this get some attention ?

grahamc · 2021-06-16T21:06:33Z

I heard from a Hashicorp person on Twitter that this PR might get looked at soon.

DrFaust92

Not a maintainer but want to help move this along

also add disappears-acceptance-tests

aws/resource_aws_ebs_snapshot_import.go

DrFaust92 · 2021-06-17T05:57:01Z

aws/resource_aws_ebs_snapshot_import.go

+	return nil
+}
+
+func importAwsEbsSnapshotWaiter(conn *ec2.EC2, importTaskID string) (*ec2.SnapshotTaskDetail, error) {


best to move to the internal service package, see https://github.com/hashicorp/terraform-provider-aws/blob/main/docs/contributing/retries-and-waiters.md#resource-attribute-value-waiters

aws/resource_aws_ebs_snapshot_import.go

aws/resource_aws_ebs_snapshot_import_test.go

DrFaust92 · 2021-06-17T06:00:11Z

aws/resource_aws_ebs_snapshot_import_test.go

+
+func TestAccAWSEBSSnapshotImport_basic(t *testing.T) {
+	var v ec2.Snapshot
+	rName := fmt.Sprintf("tf-acc-ebs-snapshot-import-basic-%s", acctest.RandString(7))


lets use the more common rName := acctest.RandomWithPrefix("tf-acc-test")

aws/resource_aws_ebs_snapshot_import.go

DrFaust92 · 2021-06-17T06:08:41Z

aws/resource_aws_ebs_snapshot_import.go

+		Read:   resourceAwsEbsSnapshotImportRead,
+		Update: resourceAwsEbsSnapshotImportUpdate,
+		Delete: resourceAwsEbsSnapshotImportDelete,


i wonder if these are needed and can use existing snapshot function similar to AMI resources. see resource_aws_ami_copy for instance

I took a look a couple days ago and didn't think that it would be worth it to pursue further. There were enough differences that (IIRC) it wouldn't be drop-in.

DrFaust92 · 2021-06-17T06:12:53Z

also add changelog file

grahamc · 2021-06-28T20:23:30Z

Thanks, @DrFaust92! I've had @cole-h help me out and address your feedback. I also rebased on main and it looks like everything is still working from here. CI is also green, but requires approval to run a few more checks.

DrFaust92 · 2021-06-29T06:59:20Z

aws/resource_aws_ebs_snapshot_import_test.go

+
+func testAccAwsEbsSnapshotImportConfigBasic(rName string, t *testing.T) string {
+	return fmt.Sprintf(`
+resource "aws_s3_bucket" "images" {


Lets extract the common part between configs for reuse

DrFaust92 · 2021-06-29T07:00:40Z

aws/resource_aws_ebs_snapshot_import_test.go

+	})
+}
+
+func TestAccAWSEBSSnapshotImport_tags(t *testing.T) {


Add tag update scenario here based on https://github.com/hashicorp/terraform-provider-aws/blob/main/docs/contributing/contribution-checklists.md#resource-tagging-acceptance-testing-implementation

DrFaust92 · 2021-06-29T07:03:27Z

aws/resource_aws_ebs_snapshot_import.go

+				Type:     schema.TypeString,
+				Computed: true,
+			},
+			"tags": tagsSchema(),


support default tags:
https://github.com/hashicorp/terraform-provider-aws/blob/main/docs/contributing/contribution-checklists.md#resource-tagging-code-implementation

cole-h · 2021-06-29T18:26:00Z

Once again, thanks for your time and review, @DrFaust92! I've fixed your suggestions in a few new commits, and testacc still passes.

cole-h · 2021-07-15T16:35:39Z

Rebased to resolve a conflict.

grahamc · 2021-07-27T17:02:13Z

❤️

grahamc · 2021-07-27T17:32:03Z

🥳 wow, thank you so much Bill!

github-actions · 2021-07-29T22:24:45Z

This functionality has been released in v3.52.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2021-08-29T02:06:13Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

grahamc requested a review from a team as a code owner November 23, 2020 14:24

github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Nov 23, 2020

grahamc commented Nov 23, 2020

View reviewed changes

grahamc force-pushed the f-aws_ebs_snapshot_import branch from dc9796a to cd6cd2a Compare November 23, 2020 14:29

github-actions bot reviewed Nov 23, 2020

View reviewed changes

grahamc force-pushed the f-aws_ebs_snapshot_import branch 3 times, most recently from 8d5c8fe to 64b1c8f Compare November 23, 2020 15:06

grahamc commented Nov 23, 2020

View reviewed changes

aws/resource_aws_ebs_snapshot_import.go Outdated Show resolved Hide resolved

grahamc force-pushed the f-aws_ebs_snapshot_import branch 3 times, most recently from e8224bb to beca575 Compare November 23, 2020 15:42

grahamc changed the title ~~aws_ebs_snapshot_import: init resource~~ aws_ebs_snapshot_import: init resource (the red X is from a panic() I don't know how to avoid) Nov 23, 2020

grahamc changed the title ~~aws_ebs_snapshot_import: init resource (the red X is from a panic() I don't know how to avoid)~~ aws_ebs_snapshot_import: init resource (the red X is from a panic() in a test which I don't know how to avoid) Nov 24, 2020

grahamc force-pushed the f-aws_ebs_snapshot_import branch from beca575 to 89e63ef Compare December 7, 2020 17:26

ghost added the documentation Introduces or discusses updates to documentation. label Dec 7, 2020

grahamc changed the title ~~aws_ebs_snapshot_import: init resource (the red X is from a panic() in a test which I don't know how to avoid)~~ aws_ebs_snapshot_import: init resource Dec 7, 2020

grahamc commented Jan 11, 2021

View reviewed changes

aws/resource_aws_ebs_snapshot_import.go Outdated Show resolved Hide resolved

grahamc force-pushed the f-aws_ebs_snapshot_import branch from 89e63ef to ce70760 Compare January 11, 2021 22:16

Base automatically changed from master to main January 23, 2021 00:59

grahamc force-pushed the f-aws_ebs_snapshot_import branch from ce70760 to 3e5589a Compare March 2, 2021 23:54

m4h3 mentioned this pull request Apr 23, 2021

Support for import-snapshot - to create ami's from s3 objects #12399

Closed

This comment has been minimized.

Sign in to view

grahamc changed the title ~~aws_ebs_snapshot_import: init resource~~ aws_ebs_snapshot_import: init resource Apr 23, 2021

DrFaust92 suggested changes Jun 17, 2021

View reviewed changes

grahamc force-pushed the f-aws_ebs_snapshot_import branch from 1522f8c to 57667a4 Compare June 28, 2021 20:02

DrFaust92 suggested changes Jun 29, 2021

View reviewed changes

DrFaust92 added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 29, 2021

cole-h force-pushed the f-aws_ebs_snapshot_import branch from 577efd5 to cb8ec76 Compare July 15, 2021 16:34

grahamc and others added 8 commits July 26, 2021 16:56

aws_ebs_snapshot_import: init

1d401ab

Address review comments

829bba7

Extract common config for reuse

a0d2e28

Support default tags

e7b1fe4

Test tag updates

a44ee82

Fix documentation code fence

7acdb69

Add ErrorCheck

5956e5c

Match existing code

4930305

bill-rich force-pushed the f-aws_ebs_snapshot_import branch from cd8233b to 4930305 Compare July 27, 2021 16:55

bill-rich merged commit cd9ff2a into hashicorp:main Jul 27, 2021

grahamc deleted the f-aws_ebs_snapshot_import branch July 27, 2021 17:31

github-actions bot added this to the v3.52.0 milestone Jul 27, 2021

github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2021

aws_ebs_snapshot_import: init resource #16373

aws_ebs_snapshot_import: init resource #16373

Uh oh!

Conversation

grahamc commented Nov 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Community Note

Uh oh!

grahamc Nov 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

grahamc commented Jan 11, 2021

Uh oh!

grahamc commented Mar 2, 2021

Uh oh!

m4h3 commented Apr 23, 2021

Uh oh!

This comment has been minimized.

grahamc commented Jun 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DrFaust92 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

DrFaust92 Jun 17, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DrFaust92 Jun 17, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DrFaust92 Jun 17, 2021

Choose a reason for hiding this comment

Uh oh!

cole-h Jun 28, 2021

Choose a reason for hiding this comment

Uh oh!

DrFaust92 commented Jun 17, 2021

Uh oh!

grahamc commented Jun 28, 2021

Uh oh!

DrFaust92 Jun 29, 2021

Choose a reason for hiding this comment

Uh oh!

DrFaust92 Jun 29, 2021

Choose a reason for hiding this comment

Uh oh!

DrFaust92 Jun 29, 2021

Choose a reason for hiding this comment

Uh oh!

cole-h commented Jun 29, 2021

Uh oh!

cole-h commented Jul 15, 2021

Uh oh!

grahamc commented Jul 27, 2021

Uh oh!

grahamc commented Jul 27, 2021

Uh oh!

github-actions bot commented Jul 29, 2021

Uh oh!

github-actions bot commented Aug 29, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

`aws_ebs_snapshot_import`: init resource #16373

`aws_ebs_snapshot_import`: init resource #16373

grahamc commented Nov 23, 2020 •

edited

Loading

grahamc Nov 23, 2020 •

edited

Loading

grahamc commented Jun 16, 2021 •

edited

Loading