Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data source for aws_ssm_patch_baseline #9486

Merged
merged 18 commits into from Jan 31, 2020
Merged

Add data source for aws_ssm_patch_baseline #9486

merged 18 commits into from Jan 31, 2020

Conversation

jdheyburn
Copy link
Contributor

@jdheyburn jdheyburn commented Jul 24, 2019

Community Note

  • Please vote on this pull request by adding a 馃憤 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #5116

Release note for CHANGELOG:

Added data source for aws_ssm_patch_baseline

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSSsmPatchBaselineDataSource_newBaseline'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSSsmPatchBaselineDataSource_newBaseline -timeout 120m
=== RUN   TestAccAWSSsmPatchBaselineDataSource_newBaseline
=== PAUSE TestAccAWSSsmPatchBaselineDataSource_newBaseline
=== CONT  TestAccAWSSsmPatchBaselineDataSource_newBaseline
--- PASS: TestAccAWSSsmPatchBaselineDataSource_newBaseline (16.39s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       16.442s

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSSsmPatchBaselineDataSource_existingBaseline'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSSsmPatchBaselineDataSource_existingBaseline -timeout 120m
=== RUN   TestAccAWSSsmPatchBaselineDataSource_existingBaseline
=== PAUSE TestAccAWSSsmPatchBaselineDataSource_existingBaseline
=== CONT  TestAccAWSSsmPatchBaselineDataSource_existingBaseline
--- PASS: TestAccAWSSsmPatchBaselineDataSource_existingBaseline (14.86s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       14.952s
...

@jdheyburn jdheyburn requested a review from Jul 24, 2019
@ghost ghost added size/L provider service/ssm tests labels Jul 24, 2019
@bflad bflad added the new-data-source label Jul 31, 2019
@jdheyburn
Copy link
Contributor Author

@jdheyburn jdheyburn commented Oct 22, 2019

I appreciate you may be busy @bflad and team, the PR has been open for 3 months now. Is there anything I can do to help this get merged?

@aeschright
Copy link
Contributor

@aeschright aeschright commented Oct 23, 2019

Hi @jdheyburn! Thanks for working on this. You'll need to back out the CHANGELOG addition -- that's something the person who merges will take care of so there aren't conflicts.

@jdheyburn
Copy link
Contributor Author

@jdheyburn jdheyburn commented Oct 30, 2019

Apologies - I've reverted the change to the CHANGELOG and updated the imports as it looks like they've changed since the PR was opened.

@jdheyburn
Copy link
Contributor Author

@jdheyburn jdheyburn commented Jan 6, 2020

Hey folks - let me know if there's anything else needed to get this forward, I appreciate the time taken to review this PR.

@bflad bflad self-assigned this Jan 30, 2020
Copy link
Member

@bflad bflad left a comment

Hey @jdheyburn 馃憢 Thank you for submitting this and apologies for the delayed review. Overall this is looking pretty good, just a few items and this should be good to go. Please reach out if you have any questions or do not have time to implement them. 馃憤

aws/ssm_patch_baseline.html.markdown Outdated Show resolved Hide resolved
aws/ssm_patch_baseline.html.markdown Outdated Show resolved Hide resolved
aws/data_source_aws_ssm_patch_baseline.go Outdated Show resolved Hide resolved
aws/data_source_aws_ssm_patch_baseline.go Outdated Show resolved Hide resolved
aws/data_source_aws_ssm_patch_baseline.go Outdated Show resolved Hide resolved
@bflad bflad added the waiting-response label Jan 30, 2020
@ghost ghost added the documentation label Jan 31, 2020
@jdheyburn jdheyburn requested a review from bflad Jan 31, 2020
@jdheyburn
Copy link
Contributor Author

@jdheyburn jdheyburn commented Jan 31, 2020

Apologies for several commits - doesn't look like the markdown was in the correct location for it to be picked up by docscheck. My branch is now so far behind it keeps missing all the new checks 馃槄

Let me know any further suggestions you might have 馃憤

@ghost ghost removed the waiting-response label Jan 31, 2020
@bflad bflad added this to the v2.48.0 milestone Jan 31, 2020
bflad
bflad approved these changes Jan 31, 2020
Copy link
Member

@bflad bflad left a comment

Thanks for those updates, @jdheyburn, looks good to me 馃殌

Output from acceptance testing:

--- PASS: TestAccAWSSsmPatchBaselineDataSource_existingBaseline (8.36s)
--- PASS: TestAccAWSSsmPatchBaselineDataSource_newBaseline (8.76s)

@bflad bflad merged commit 391402b into hashicorp:master Jan 31, 2020
1 check passed
bflad added a commit that referenced this issue Jan 31, 2020
@ghost
Copy link

@ghost ghost commented Feb 7, 2020

This has been released in version 2.48.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

@ghost ghost commented Mar 27, 2020

I'm going to lock this issue because it has been closed for 30 days . This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation new-data-source provider service/ssm size/L tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants