Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource: azurerm_virtual_hub_route_table_route #13743

Merged
merged 5 commits into from Oct 21, 2021
Merged

New Resource: azurerm_virtual_hub_route_table_route #13743

merged 5 commits into from Oct 21, 2021

Conversation

josh-barker
Copy link
Contributor

@josh-barker josh-barker commented Oct 15, 2021 •
edited

This PR addresses #11169

This was referenced Oct 15, 2021
Closed
Closed
jackofallops
jackofallops requested changes Oct 20, 2021
View reviewed changes
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @josh-barker - Thanks for this new virtual resource. It's off to a good start and I've made some suggestions / recommendations inline below. If you can take a look at those we'll continue the review.

Thanks!

internal/services/network/virtual_hub_route_resource.go Outdated Show resolved Hide resolved
internal/services/network/virtual_hub_route_resource.go Outdated Show resolved Hide resolved
website/docs/r/virtual_hub_route.html.markdown Outdated Show resolved Hide resolved
internal/services/network/registration.go Outdated Show resolved Hide resolved
internal/services/network/virtual_hub_route_resource.go Outdated Show resolved Hide resolved
internal/services/network/virtual_hub_route_resource.go Outdated Show resolved Hide resolved
internal/services/network/virtual_hub_route_resource.go Outdated Show resolved Hide resolved
internal/services/network/virtual_hub_route_resource.go Outdated Show resolved Hide resolved
internal/services/network/virtual_hub_route_resource.go Outdated Show resolved Hide resolved
internal/services/network/virtual_hub_route_resource.go Outdated Show resolved Hide resolved
@josh-barker
Copy link
Contributor Author

Hey @jackofallops, thanks for the feedback. I've implemented all of the requested changes.

@katbyte katbyte added this to the v2.82.0 milestone Oct 21, 2021
katbyte
katbyte approved these changes Oct 21, 2021
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @josh-barker - LGTM 🍰

@katbyte katbyte changed the title feat: create virtual hub route resource New Resource: azurerm_virtual_hub_route_table_route Oct 21, 2021
@katbyte katbyte merged commit 746fffa into hashicorp:main Oct 21, 2021
katbyte added a commit that referenced this pull request Oct 21, 2021
@katbyte
CHANGELOG.md for #13743
445e07c
@github-actions
Copy link

This functionality has been released in v2.82.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@josh-barker josh-barker mentioned this pull request Oct 22, 2021
Merged
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jackofallops jackofallops jackofallops requested changes

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
documentation service/virtual-hub size/XL
Projects
None yet
Milestone
v2.82.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@josh-barker @katbyte @jackofallops