Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kusto_database support data source kusto_database_data_source.go #16180

Merged

Conversation

qiqingzhang
Copy link
Contributor

@qiqingzhang qiqingzhang commented Mar 31, 2022

create a public pull request for kusto_database support data source kusto_database_data_source.go

Link to #15133

@qiqingzhang qiqingzhang force-pushed the branch-add_kusto_database_data_source.go branch from ef258a4 to d91762e Compare April 6, 2022 06:31
Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @heiazuo. I've left a couple of minor comments inline bu overall this is looking good so far. Thanks!

website/docs/d/kusto_database.html.markdown Outdated Show resolved Hide resolved
website/docs/d/kusto_database.html.markdown Outdated Show resolved Hide resolved
website/docs/d/kusto_database.html.markdown Outdated Show resolved Hide resolved
internal/services/kusto/kusto_database_data_source.go Outdated Show resolved Hide resolved
internal/services/kusto/kusto_database_data_source.go Outdated Show resolved Hide resolved
@qiqingzhang
Copy link
Contributor Author

Thanks@catriona-m ,thanks for your suggestion, I made the changes as suggested

@catriona-m
Copy link
Member

Thanks for updating this @heiazuo. Looks like there is a test failure, once this is fixed we can look at merging this. Thanks!

------- Stdout: -------
=== RUN   TestAccKustoDatabaseDataSource_basic
=== PAUSE TestAccKustoDatabaseDataSource_basic
=== CONT  TestAccKustoDatabaseDataSource_basic
testing_new_config.go:111: no "id" found in attributes
testing_new.go:53: no "id" found in attributes
--- FAIL: TestAccKustoDatabaseDataSource_basic (764.37s)
FAIL

1 similar comment
@catriona-m
Copy link
Member

Thanks for updating this @heiazuo. Looks like there is a test failure, once this is fixed we can look at merging this. Thanks!

------- Stdout: -------
=== RUN   TestAccKustoDatabaseDataSource_basic
=== PAUSE TestAccKustoDatabaseDataSource_basic
=== CONT  TestAccKustoDatabaseDataSource_basic
testing_new_config.go:111: no "id" found in attributes
testing_new.go:53: no "id" found in attributes
--- FAIL: TestAccKustoDatabaseDataSource_basic (764.37s)
FAIL

Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating @heiazuo. I ran the test again and it looks like there is still a failure here:

------- Stdout: -------
=== RUN   TestAccKustoDatabaseDataSource_basic
=== PAUSE TestAccKustoDatabaseDataSource_basic
=== CONT  TestAccKustoDatabaseDataSource_basic
testcase.go:110: Step 1/1 error: Check failed: Check 2/4 error: data.azurerm_kusto_database.test: Attribute 'soft_delete_period' expected to be set
--- FAIL: TestAccKustoDatabaseDataSource_basic (2646.59s)
FAIL

Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @heiazuo LGTM! 🦩

@catriona-m catriona-m merged commit 477ac98 into hashicorp:main Apr 11, 2022
@github-actions github-actions bot added this to the v3.2.0 milestone Apr 11, 2022
@github-actions
Copy link

This functionality has been released in v3.2.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants