Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_stream_analytics_output_blob - support new property authentication_mode #16652

Merged
merged 8 commits into from
Jul 14, 2022
Merged

azurerm_stream_analytics_output_blob - support new property authentication_mode #16652

merged 8 commits into from
Jul 14, 2022

Conversation

neil-yechenwei
Copy link
Contributor

fixes #12718

--- PASS: TestAccStreamAnalyticsOutputBlob_json (277.07s)
--- PASS: TestAccStreamAnalyticsOutputBlob_csv (290.52s)
--- PASS: TestAccStreamAnalyticsOutputBlob_avro (295.24s)
--- PASS: TestAccStreamAnalyticsOutputBlob_parquet (296.61s)
--- PASS: TestAccStreamAnalyticsOutputBlob_requiresImport (332.44s)
--- PASS: TestAccStreamAnalyticsOutputBlob_update (424.15s)
--- PASS: TestAccStreamAnalyticsOutputBlob_authenticationMode (409.24s)

tombuildsstuff
tombuildsstuff reviewed Jun 29, 2022
View reviewed changes
internal/services/streamanalytics/stream_analytics_output_blob_resource.go Outdated
if !ok {
return fmt.Errorf("converting Output Data Source to a Blob Output: %+v", id)
}
(*blobOutputDataSource.StorageAccounts)[0].AccountKey = utils.String(v.(string))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this isn't guaranteed, particularly with upcoming changes to the SDK - we'll want to set this back to props.Datasource

Copy link
Contributor Author

@neil-yechenwei neil-yechenwei Jun 30, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@neil-yechenwei
Copy link
Contributor Author

neil-yechenwei commented Jun 30, 2022 •
edited
Loading

@tombuildsstuff , I've updated code. Please have a look. Thanks.

katbyte
katbyte approved these changes Jul 14, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎩

@katbyte katbyte merged commit 6aaf2b6 into hashicorp:main Jul 14, 2022
@github-actions github-actions bot added this to the v3.14.0 milestone Jul 14, 2022
katbyte added a commit that referenced this pull request Jul 14, 2022
@katbyte
CHANGELOG #16652
58d619e
@github-actions
Copy link

This functionality has been released in v3.14.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

@tombuildsstuff tombuildsstuff Awaiting requested review from tombuildsstuff

Assignees
No one assigned
Labels
documentation service/stream-analytics size/M
Projects
None yet
Milestone
v3.14.0
Development

Successfully merging this pull request may close these issues.

Support for using managed identity in azurerm_stream_analytics_output_blob
3 participants
@neil-yechenwei @tombuildsstuff @katbyte