New resource - azurerm_active_directory_domain_service_trust

[magodo]

This PR adds a new resource azurerm_active_directory_domain_service_trust, which is actually a property of the Azure resource: Azure Active Directory Domain Service. This modeling is inspired by the corresponding powershell cmdlet.

This resource represents a trust relationship between an AADDS and a on-premise ADDS. To setup the E2E testing, there are following steps needed:

• Setup a on-premise ADDS (manually)
• Setup an AADDS (can via Terraform)
• Setup the network for the on-premise ADDS and the AADDS (can via Terraform)
• Configure DNS in the on-premise ADDS (manually)
• Create an inbound trust in the on-premise ADDS (manually)

(See: https://docs.microsoft.com/en-us/azure/active-directory-domain-services/tutorial-create-forest-trust)

Therefore, in the acctest, I'm passing in all the needed information which are setup previously via env vars. Also the tests are run in sequential, as at most there is only one AADDS in each tenant.

Test Result

❯ TF_ACC=1 go test -timeout=60m -v -run='TestAccDomainServiceTrust_' ./internal/services/domainservices
=== RUN   TestAccDomainServiceTrust_basic
--- PASS: TestAccDomainServiceTrust_basic (187.35s)
=== RUN   TestAccDomainServiceTrust_requiresImport
--- PASS: TestAccDomainServiceTrust_requiresImport (193.09s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/domainservices        380.445s

[manicminer]

Hi @magodo, thanks for this PR! I've made some minor comments below and I'm going to have a go at running these tests later today.

[magodo]

@manicminer Is there anything I can do to make this PR merge?

[manicminer]

@magodo Thanks for updating. We don't have a way to easily test at the moment but this LGTM and it's passing for you. Thanks again 👍

[github-actions]

This functionality has been released in v3.12.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.