Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_servicebus_subscription_rule - correlation_filter with empty attributes no longer crashes #19352

Merged
merged 1 commit into from Nov 18, 2022

Conversation

mbfrahry
Copy link
Member

Fixes #18891

Unfortunately, there isn't a way in Terraform to just specify an empty label without any other attributes specified. This at least fixes the panic and returns an error if no attributes are specified under a correlation_filter

--- PASS: TestAccServiceBusSubscriptionRule_correlationFilterWhiteSpace (323.73s)

Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🧇

@mbfrahry mbfrahry merged commit d69f6e4 into main Nov 18, 2022
@mbfrahry mbfrahry deleted the c-sb-sub-rule-correlation-filter branch November 18, 2022 18:24
@github-actions github-actions bot added this to the v3.33.0 milestone Nov 18, 2022
mbfrahry added a commit that referenced this pull request Nov 18, 2022
@github-actions
Copy link

This functionality has been released in v3.33.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_servicebus_subscription_rule correlation_filter with whitespace label causes crash
2 participants