Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_virtual_hub - feat: add hub_routing_preference to virtual hub resource #21028

Merged
merged 1 commit into from Mar 21, 2023
Merged

azurerm_virtual_hub - feat: add hub_routing_preference to virtual hub resource #21028

merged 1 commit into from Mar 21, 2023

Conversation

josh-barker
Copy link
Contributor

@josh-barker josh-barker commented Mar 20, 2023 •
edited

Address #19911

@josh-barker josh-barker marked this pull request as ready for review March 20, 2023 04:29
catriona-m
catriona-m requested changes Mar 20, 2023
View reviewed changes
Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @josh-barker thanks for this. Just left one minor comment, otherwise this is looking pretty good!

@katbyte katbyte changed the title feat: add hub_routing_preference to virtual hub resource azurerm_virtual_hub - feat: add hub_routing_preference to virtual hub resource Mar 21, 2023
katbyte
katbyte approved these changes Mar 21, 2023
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @josh-barker - LGTM 🦺

@katbyte katbyte merged commit ba18a21 into hashicorp:main Mar 21, 2023
13 checks passed
katbyte added a commit that referenced this pull request Mar 21, 2023
@katbyte
Update CHANGELOG.md #21028
89a05e2
@github-actions github-actions bot added this to the v3.49.0 milestone Mar 21, 2023
@josh-barker josh-barker deleted the feat/vhub-routing-preference branch March 21, 2023 22:11
@github-actions
Copy link

This functionality has been released in v3.49.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

@catriona-m catriona-m Awaiting requested review from catriona-m

Assignees
No one assigned
Labels
documentation service/network size/S
Projects
None yet
Milestone
v3.49.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@josh-barker @katbyte @catriona-m