Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_[linux|windows]_[function|web]_app[_slot] - Fix another nilpointer for auth_v2 #21381

Merged
merged 2 commits into from Apr 12, 2023

Conversation

aristosvo
Copy link
Collaborator

@aristosvo aristosvo commented Apr 11, 2023

Fixes #21375

❯ go install && make acctests SERVICE='appservice' TESTARGS='-run=TestAccLinuxFunctionApp_authV2AzureActiveDirectory'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/appservice -run=TestAccLinuxFunctionApp_authV2AzureActiveDirectory -timeout 180m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccLinuxFunctionApp_authV2AzureActiveDirectory
=== PAUSE TestAccLinuxFunctionApp_authV2AzureActiveDirectory
=== RUN   TestAccLinuxFunctionApp_authV2AzureActiveDirectoryRemove
=== PAUSE TestAccLinuxFunctionApp_authV2AzureActiveDirectoryRemove
=== CONT  TestAccLinuxFunctionApp_authV2AzureActiveDirectory
=== CONT  TestAccLinuxFunctionApp_authV2AzureActiveDirectoryRemove
--- PASS: TestAccLinuxFunctionApp_authV2AzureActiveDirectory (266.30s)
--- PASS: TestAccLinuxFunctionApp_authV2AzureActiveDirectoryRemove (309.23s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/appservice      311.203s

@aristosvo aristosvo marked this pull request as ready for review April 11, 2023 20:00
@aristosvo aristosvo changed the title azurerm_[linux|windows]_[function|web]_app[_slot] - Fix nilpointer auth_v2 again including test azurerm_[linux|windows]_[function|web]_app[_slot] - Fix another nilpointer for auth_v2 Apr 11, 2023
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aristosvo - LGMT 👍

@jackofallops jackofallops merged commit 87eb5f7 into hashicorp:main Apr 12, 2023
13 checks passed
@github-actions github-actions bot added this to the v3.52.0 milestone Apr 12, 2023
jackofallops added a commit that referenced this pull request Apr 12, 2023
@aristosvo aristosvo deleted the appsvc/nilpointer-3 branch April 12, 2023 09:54
@github-actions
Copy link

This functionality has been released in v3.52.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@aristosvo aristosvo restored the appsvc/nilpointer-3 branch April 14, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform-provider-azurerm_v3.51.0_x5 plugin crashed
2 participants