Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_kubernetes_cluster - mark ebpf_data_plane not force new #22952

Merged
merged 6 commits into from
Aug 21, 2023
Merged

azurerm_kubernetes_cluster - mark ebpf_data_plane not force new #22952

merged 6 commits into from
Aug 21, 2023

Conversation

ms-henglu
Copy link
Contributor

@ms-henglu ms-henglu commented Aug 15, 2023 •
edited
Loading

fixes #22918

image

stephybun
stephybun requested changes Aug 16, 2023
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ms-henglu could you do a rebase please to fix the CI?

@ms-henglu
Copy link
Contributor Author

Hi @stephybun ,

Thanks! I've rebased this PR, please take another look.

@ms-henglu @stephybun
Update internal/services/containers/kubernetes_cluster_resource.go
2a8e8c1 
Co-authored-by: stephybun <steph@hashicorp.com>
stephybun
stephybun requested changes Aug 18, 2023
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ms-henglu this is good to go after the merge conflict has been resolved.

stephybun
stephybun approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ms-henglu LGTM 👍

@stephybun stephybun merged commit 8304b12 into hashicorp:main Aug 21, 2023
23 checks passed
@github-actions github-actions bot added this to the v3.71.0 milestone Aug 21, 2023
stephybun added a commit that referenced this pull request Aug 24, 2023
@stephybun
Update for #22952
dffbd89
@derek-andrews-work derek-andrews-work mentioned this pull request Sep 20, 2023
Closed
1 task
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephybun stephybun stephybun approved these changes

Assignees
No one assigned
Labels
documentation enhancement service/kubernetes-cluster size/S
Projects
None yet
Milestone
v3.71.0
Development

Successfully merging this pull request may close these issues.

azurerm_kubernetes_cluster - do not force replacement when enabling cilium on existing cluster
2 participants
@ms-henglu @stephybun