Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_shared_image_gallery: support directly sharing #23570

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

ziyeqf
Copy link
Contributor

@ziyeqf ziyeqf commented Oct 16, 2023

fix #18326

test

❯ tftest compute TestAccSharedImageGallery                                            
=== RUN   TestAccSharedImageGallery_basic
=== PAUSE TestAccSharedImageGallery_basic
=== RUN   TestAccSharedImageGallery_requiresImport
=== PAUSE TestAccSharedImageGallery_requiresImport
=== RUN   TestAccSharedImageGallery_complete
=== PAUSE TestAccSharedImageGallery_complete
=== RUN   TestAccSharedImageGallery_update
=== PAUSE TestAccSharedImageGallery_update
=== RUN   TestAccSharedImageGallery_communityGallery
=== PAUSE TestAccSharedImageGallery_communityGallery
=== RUN   TestAccSharedImageGallery_groupsGallery
=== PAUSE TestAccSharedImageGallery_groupsGallery
=== RUN   TestAccSharedImageGallery_privateGallery
=== PAUSE TestAccSharedImageGallery_privateGallery
=== CONT  TestAccSharedImageGallery_basic
=== CONT  TestAccSharedImageGallery_communityGallery
=== CONT  TestAccSharedImageGallery_privateGallery
=== CONT  TestAccSharedImageGallery_groupsGallery
=== CONT  TestAccSharedImageGallery_complete
=== CONT  TestAccSharedImageGallery_update
=== CONT  TestAccSharedImageGallery_requiresImport
--- PASS: TestAccSharedImageGallery_requiresImport (211.83s)
--- PASS: TestAccSharedImageGallery_update (340.38s)
--- PASS: TestAccSharedImageGallery_complete (741.47s)
--- PASS: TestAccSharedImageGallery_privateGallery (774.48s)
--- PASS: TestAccSharedImageGallery_groupsGallery (785.27s)
--- PASS: TestAccSharedImageGallery_communityGallery (817.92s)
--- PASS: TestAccSharedImageGallery_basic (818.13s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/compute       819.789s

Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ziyeqf LGTM!

@catriona-m catriona-m merged commit 9a038f2 into hashicorp:main Oct 16, 2023
22 checks passed
@github-actions github-actions bot added this to the v3.77.0 milestone Oct 16, 2023
catriona-m added a commit that referenced this pull request Oct 16, 2023
dduportal pushed a commit to jenkins-infra/azure that referenced this pull request Oct 20, 2023
<Actions>
<action
id="4a39167e811ac038e4a588362092472c27cfbe9e4929ae61d035f708a093a669">
        <h3>Bump Terraform `azurerm` provider version</h3>
<details
id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24">
            <summary>Update Terraform lock file</summary>
<p>&#34;hashicorp/azurerm&#34; updated from &#34;3.76.0&#34; to
&#34;3.77.0&#34; in file &#34;.terraform.lock.hcl&#34;</p>
            <details>
                <summary>3.77.0</summary>
<pre>Changelog retrieved
from:&#xA;&#x9;https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.77.0&#xA;FEATURES:&#xA;&#xA;*
New Resources: `azurerm_application_load_balancer_frontend`
([#23411](https://github.com/hashicorp/terraform-provider-azurerm/issues/23411))&#xA;*
New Resources: `azurerm_dev_center`
([#23538](https://github.com/hashicorp/terraform-provider-azurerm/issues/23538))&#xA;*
New Resources: `azurerm_dev_center_project`
([#23538](https://github.com/hashicorp/terraform-provider-azurerm/issues/23538))&#xA;&#xA;ENHANCEMENTS:&#xA;&#xA;*
dependencies: updating to `v0.62.0` of
`github.com/hashicorp/go-azure-helpers`
([#23581](https://github.com/hashicorp/terraform-provider-azurerm/issues/23581))&#xA;*
dependencies: updating Kusto SDK from `2023-05-02` to `2023-08-15`
([#23598](https://github.com/hashicorp/terraform-provider-azurerm/issues/23598))&#xA;*
dependencies: updating nginx from `2022-08-01` to `2023-04-01`
([#23583](https://github.com/hashicorp/terraform-provider-azurerm/issues/23583))&#xA;*
`netapp`: updating to use API Version `2023-05-01`
([#23576](https://github.com/hashicorp/terraform-provider-azurerm/issues/23576))&#xA;*
`springcloud`: updating to use API Version `2023-09-01-preview`
([#23544](https://github.com/hashicorp/terraform-provider-azurerm/issues/23544))&#xA;*
`storage`: updating to use API Version `2023-01-01`
([#23543](https://github.com/hashicorp/terraform-provider-azurerm/issues/23543))&#xA;*
`internal/sdk`: fixing an issue where struct fields containing
`removedInNextMajorVersion` wouldn&#39;t be decoded correctly
([#23564](https://github.com/hashicorp/terraform-provider-azurerm/issues/23564))&#xA;*
`internal/sdk`: struct tag parsing is now handled consistently during
both encoding and decoding
([#23568](https://github.com/hashicorp/terraform-provider-azurerm/issues/23568))&#xA;*
provider: the `roll_instances_when_required` provider feature in the
`virtual_machine_scale_set` block is now optional
([#22976](https://github.com/hashicorp/terraform-provider-azurerm/issues/22976))&#xA;*
Data Source: `azurerm_automation_account`: refactoring the remaining
usage of `Azure/azure-sdk-for-go` to use `hashicorp/go-azure-sdk`
([#23555](https://github.com/hashicorp/terraform-provider-azurerm/issues/23555))&#xA;*
`azurerm_automation_account`: refactoring the remaining usage of
`Azure/azure-sdk-for-go` to use `hashicorp/go-azure-sdk`
([#23555](https://github.com/hashicorp/terraform-provider-azurerm/issues/23555))&#xA;*
`azurerm_resource_deployment_script_azure_cli` - improve validation for
the `version` property to support newer versions
([#23370](https://github.com/hashicorp/terraform-provider-azurerm/issues/23370))&#xA;*
`azurerm_resource_deployment_script_azure_power_shell` - improve
validation for the `version` property to support newer versions
([#23370](https://github.com/hashicorp/terraform-provider-azurerm/issues/23370))&#xA;*
`azurerm_nginx_deployment` - support for the `capacity` and `email`
properties
([#23596](https://github.com/hashicorp/terraform-provider-azurerm/issues/23596))&#xA;&#xA;BUG
FIXES:&#xA;&#xA;* Data Source: `azurerm_virtual_hub_connection` - export
the `inbound_route_map_id`, `outbound_route_map_id`, and
`static_vnet_local_route_override_criteria` attributes in the `routing`
block, and fix a bug where these attributes could not be set
([#23491](https://github.com/hashicorp/terraform-provider-azurerm/issues/23491))&#xA;*
`azurerm_cdn_frontdoor_rule` - the `url_filename_condition` properties
`match_values` is now optional if `operator` is set to `Any`
([#23541](https://github.com/hashicorp/terraform-provider-azurerm/issues/23541))&#xA;*
`azurerm_shared_image_gallery` - added the `Private` and `Groups`
options for the `sharing.permission` property
([#23570](https://github.com/hashicorp/terraform-provider-azurerm/issues/23570))&#xA;*
`azurerm_redis_cache` - fixed incorrect ssl values for
`redis_primary_connection_string` and `secondary_connection_string`
([#23575](https://github.com/hashicorp/terraform-provider-azurerm/issues/23575))&#xA;*
`azurerm_monitor_activity_log_alert` - the `recommend_category` property
now can be set to `HighAvailability`
([#23605](https://github.com/hashicorp/terraform-provider-azurerm/issues/23605))&#xA;*
`azurerm_recovery_services_vault` - the `encryption` property can now be
used with the `cross_region_restore_enabled` property
([#23618](https://github.com/hashicorp/terraform-provider-azurerm/issues/23618))&#xA;*
`azurerm_storage_account_customer_managed_key` - prevent a panic when
the keyvault id is empty
([#23599](https://github.com/hashicorp/terraform-provider-azurerm/issues/23599))&#xA;&#xA;&#xA;</pre>
            </details>
        </details>
    </action>
</Actions>

---

<table>
  <tr>
    <td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
    </td>
    <td>
      <p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
      </p>
      <details><summary>Options:</summary>
        <br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
        <ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
        </ul>
        <p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
        </p>
      </details>
    </td>
  </tr>
</table>

Co-authored-by: Jenkins Infra Bot (updatecli) <60776566+jenkins-infra-bot@users.noreply.github.com>
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for DirectShared Gallery
2 participants