Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r\shared_image_version: add support for disk_encryption_set_id end_of_life_date replication_mode #17295

Merged
merged 3 commits into from Jun 28, 2022

Conversation

@myc2h6o
Copy link
Contributor Author

myc2h6o commented Jun 20, 2022

Test result: (failed tests failed on main as well due to dangling os disk, to be fixed by #17297)
---
Update: above fix pr is merged, updated test result:
image

@myc2h6o myc2h6o force-pushed the image_version branch 5 times, most recently from 4f4c4fe to 8665d01 Compare June 25, 2022 07:45
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦕

@katbyte
Copy link
Collaborator

katbyte commented Jun 28, 2022

once merge conflicts are resolved

@myc2h6o
Copy link
Contributor Author

myc2h6o commented Jun 28, 2022

Hi @katbyte thanks for reviewing the pr! I've resolved the merge conflicts. Below is the updated test result:
image

@katbyte katbyte merged commit c59978b into hashicorp:main Jun 28, 2022
@github-actions github-actions bot added this to the v3.12.0 milestone Jun 28, 2022
katbyte added a commit that referenced this pull request Jun 28, 2022
@myc2h6o myc2h6o deleted the image_version branch June 28, 2022 23:10
@github-actions
Copy link

github-actions bot commented Jul 1, 2022

This functionality has been released in v3.12.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Aug 1, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants