Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_bot_channels_registration - support streaming_endpoint_enabled #17369

Merged
merged 3 commits into from Jun 28, 2022
Merged

azurerm_bot_channels_registration - support streaming_endpoint_enabled #17369

merged 3 commits into from Jun 28, 2022

Conversation

neil-yechenwei
Copy link
Contributor

@neil-yechenwei neil-yechenwei commented Jun 24, 2022 •
edited

fixes #17320

image

@neil-yechenwei
Copy link
Contributor Author

@stephybun ,thanks for your comment. I've updated code. Please take another look. Thanks in advance.

@neil-yechenwei neil-yechenwei changed the title azurerm_bot_channels_registration - support is_streaming_endpoint_enabled azurerm_bot_channels_registration - support streaming_endpoint_enabled Jun 27, 2022
@neil-yechenwei
Copy link
Contributor Author

neil-yechenwei commented Jun 27, 2022 •
edited

@stephybun ,thanks for your comment. I've updated PR. Please take another look. Thanks.

katbyte
katbyte approved these changes Jun 28, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @neil-yechenwei - LGTM 🍰

@katbyte katbyte merged commit 931f8ed into hashicorp:main Jun 28, 2022
katbyte added a commit that referenced this pull request Jun 28, 2022
@katbyte
CHBANGELOG.md for #17369
4be8ade
@github-actions github-actions bot added this to the v3.12.0 milestone Jun 28, 2022
@FarihahHamizan
Copy link

FarihahHamizan commented Jun 28, 2022 •
edited

Is it possible to do the same changes for azurerm_bot_service_azure_bot resource? @katbyte I am currently using azure bot and I need the same configuration for directline speech

@github-actions
Copy link

github-actions bot commented Jul 1, 2022

This functionality has been released in v3.12.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Aug 1, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

@stephybun stephybun Awaiting requested review from stephybun

Assignees
No one assigned
Labels
documentation enhancement service/bots size/M
Projects
None yet
Milestone
v3.12.0
Development

Successfully merging this pull request may close these issues.

Support for Enabling Streaming Endpoint on Azure Bot For Directline Speech
4 participants
@neil-yechenwei @FarihahHamizan @katbyte @stephybun