Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add files for gha release workflow #10576

Merged
merged 5 commits into from Nov 19, 2021
Merged

add files for gha release workflow #10576

merged 5 commits into from Nov 19, 2021

Conversation

megan07
Copy link
Contributor

@megan07 megan07 commented Nov 17, 2021

Adding the appropriate files for automated releases with GHA

@github-actions github-actions bot added size/l and removed size/m labels Nov 17, 2021
@@ -1,31 +0,0 @@
#!/bin/bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this is an interesting one..this script is usually run by the TeamCity configuration? perhaps to re-use this behavior, an additional job in the release.yml can run this script and commit the updated changelog file🤔 in the awscc provider i guess we haven't run into many situations where the changelog entries are referencing specific PRs so that part has been pretty manual

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah! gotcha, i just read in the RFC that we could remove this. for tpg/tpgb we generate our changelog entries anyway. i'll have to look at that changelog generation to see if our changelog generates to the [GH-nnnn] format or just includes the links? I'd assume the latter, but will double-check! Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For documentation sake, it does look like changelog-gen adds the full link in, so this shouldn't be an issue. i believe.

Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only major addition needed would be to make sure goreleaser creates the 2 signature files (one with the public key in the filename and one without) as described in the comments, otherwise this LGTM 👍 I dropped in a suggestion related to the changelong-links script as I haven't dealt with that yet but lmk your thoughts 😄

megan07 and others added 2 commits November 19, 2021 12:33
Co-authored-by: angie pinilla <angelinepinilla@gmail.com>
@megan07 megan07 requested a review from anGie44 November 19, 2021 18:46
Copy link
Collaborator

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what all of the parts of this do precisely but this seems reasonable.

@megan07 megan07 merged commit 1c97467 into master Nov 19, 2021
nat-henderson pushed a commit that referenced this pull request Nov 22, 2021
* add files for gha release workflow

* remove changelog-links script, no longer needed

* Update .goreleaser.yml

Co-authored-by: angie pinilla <angelinepinilla@gmail.com>

* changes for sdkv2

* remove extra sig block

Co-authored-by: angie pinilla <angelinepinilla@gmail.com>
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants