From 50e1b8394d264b8e33de614c65b0df646b3f2ac8 Mon Sep 17 00:00:00 2001 From: Patrick Decat Date: Wed, 19 Feb 2020 18:13:47 +0100 Subject: [PATCH] Use TestStep.ExpectedDiffChanges() to ensure resources are properly created/updated/recreate between acceptance test steps --- kubernetes/resource_kubernetes_job_test.go | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/kubernetes/resource_kubernetes_job_test.go b/kubernetes/resource_kubernetes_job_test.go index 2a48daf446..851a34c874 100644 --- a/kubernetes/resource_kubernetes_job_test.go +++ b/kubernetes/resource_kubernetes_job_test.go @@ -22,7 +22,8 @@ func TestAccKubernetesJob_basic(t *testing.T) { CheckDestroy: testAccCheckKubernetesJobDestroy, Steps: []resource.TestStep{ { - Config: testAccKubernetesJobConfig_basic(name), + Config: testAccKubernetesJobConfig_basic(name), + ExpectedDiffChanges: map[string]terraform.DiffChangeType{"kubernetes_job.test": terraform.DiffCreate}, Check: resource.ComposeAggregateTestCheckFunc( testAccCheckKubernetesJobExists("kubernetes_job.test", &conf), resource.TestCheckResourceAttr("kubernetes_job.test", "metadata.0.name", name), @@ -40,7 +41,8 @@ func TestAccKubernetesJob_basic(t *testing.T) { ), }, { - Config: testAccKubernetesJobConfig_modified(name), + Config: testAccKubernetesJobConfig_modified(name), + ExpectedDiffChanges: map[string]terraform.DiffChangeType{"kubernetes_job.test": terraform.DiffUpdate}, Check: resource.ComposeAggregateTestCheckFunc( testAccCheckKubernetesJobExists("kubernetes_job.test", &conf), resource.TestCheckResourceAttr("kubernetes_job.test", "metadata.0.name", name), @@ -60,7 +62,8 @@ func TestAccKubernetesJob_basic(t *testing.T) { ), }, { - Config: testAccKubernetesJobConfig_recreated_selector(name), + Config: testAccKubernetesJobConfig_recreated_selector(name), + ExpectedDiffChanges: map[string]terraform.DiffChangeType{"kubernetes_job.test": terraform.DiffDestroyCreate}, Check: resource.ComposeAggregateTestCheckFunc( testAccCheckKubernetesJobExists("kubernetes_job.test", &conf), resource.TestCheckResourceAttr("kubernetes_job.test", "metadata.0.name", name), @@ -82,7 +85,8 @@ func TestAccKubernetesJob_basic(t *testing.T) { ), }, { - Config: testAccKubernetesJobConfig_recreated_image(name), + Config: testAccKubernetesJobConfig_recreated_image(name), + ExpectedDiffChanges: map[string]terraform.DiffChangeType{"kubernetes_job.test": terraform.DiffDestroyCreate}, Check: resource.ComposeAggregateTestCheckFunc( testAccCheckKubernetesJobExists("kubernetes_job.test", &conf), resource.TestCheckResourceAttr("kubernetes_job.test", "metadata.0.name", name),