Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nerf the job monitoring when update does not produce a deployment #116

Merged
merged 4 commits into from
Jun 10, 2020

Conversation

cgbaker
Copy link
Contributor

@cgbaker cgbaker commented Jun 9, 2020

No description provided.

@ghost ghost added the size/XL label Jun 9, 2020
lgfa29
lgfa29 previously approved these changes Jun 9, 2020
Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL about WaitForState, looks pretty useful.

Minor bikeshedding to make my editor happy, but this looks good 👍

nomad/resource_job.go Outdated Show resolved Hide resolved
nomad/resource_job.go Outdated Show resolved Hide resolved
nomad/resource_job.go Outdated Show resolved Hide resolved
nomad/resource_job.go Outdated Show resolved Hide resolved
nomad/resource_job.go Outdated Show resolved Hide resolved
nomad/resource_job.go Outdated Show resolved Hide resolved
nomad/resource_job.go Outdated Show resolved Hide resolved
nomad/resource_job.go Outdated Show resolved Hide resolved
nomad/resource_job.go Outdated Show resolved Hide resolved
@cgbaker cgbaker force-pushed the b-109-monitoring-batch-jobs branch from d872adb to fa45018 Compare June 10, 2020 12:30
@cgbaker cgbaker requested a review from lgfa29 June 10, 2020 12:35
@cgbaker cgbaker merged commit 37abf9d into master Jun 10, 2020
@cgbaker cgbaker deleted the b-109-monitoring-batch-jobs branch June 10, 2020 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants