Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to 1.7.1 and add token_name_format to resource_acl_auth_method #403

Merged
merged 3 commits into from
Dec 15, 2023

Conversation

the-nando
Copy link
Contributor

@the-nando the-nando commented Dec 13, 2023

Fixes #394

@the-nando the-nando force-pushed the feature/acl_auth_method-token-name branch 4 times, most recently from 5a2eb3b to 2e6700a Compare December 14, 2023 07:34
@lgfa29 lgfa29 force-pushed the feature/acl_auth_method-token-name branch from 9908b6a to 1a02e7c Compare December 15, 2023 21:07
Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the great PR @the-nando!

I had updated Nomad to 1.7.2 in #404 so I rebased and force-pushed to your branch to pick that up. Releases have been rolling out quickly 😬

@lgfa29 lgfa29 merged commit d69ce5d into hashicorp:main Dec 15, 2023
3 checks passed
@IamTheFij
Copy link
Contributor

Noting that this introduces a bug. This field is optional without a default value, yet the server provides a default value when requesting the resource. This results in Terraform always thinking there is a change and “removing” the value.

For example:

Terraform will perform the following actions:

  # module.core.nomad_acl_auth_method.nomad_authelia will be updated in-place
  ~ resource "nomad_acl_auth_method" "nomad_authelia" {
        id                = "authelia"
        name              = "authelia"
      - token_name_format = "${auth_method_type}-${auth_method_name}" -> null
        # (4 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.
module.core.nomad_acl_auth_method.nomad_authelia: Modifying... [id=authelia]
module.core.nomad_acl_auth_method.nomad_authelia: Modifications complete after 0s [id=authelia]

Apply complete! Resources: 0 added, 1 changed, 0 destroyed.

I’ll report an issue as well when I have a bit more time, but I thought it may help to provide this along with the context of the original change as well.

@lgfa29
Copy link
Contributor

lgfa29 commented Mar 12, 2024

Thanks for the report @IamTheFij!

Sorry I missed this earlier, GitHub notifications can be a little weird, so opening an issue and linking to the PR is usually better way to get our attention 😅

I've opened #442 to fix the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

acl_auth_method: add token name format parameter
3 participants