Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds description parameter to TFE Workspace #271

Merged
merged 1 commit into from Apr 20, 2021

Conversation

petems
Copy link
Contributor

@petems petems commented Feb 16, 2021

  • Requires go-tfe update

Description

Adds description to workspace

External links

Include any links here that might be helpful for people reviewing your PR. If there are none, feel free to delete this section.

https://www.terraform.io/docs/cloud/api/workspaces.html#request-body

data.attributes.description string (nothing) A description for the workspace.

Required in create and read

Copy link
Member

@chrisarcand chrisarcand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Needs some test additions 💞
  • Run a go mod tidy to remove the 0.12.0 refs, too.

tfe/resource_tfe_workspace.go Outdated Show resolved Hide resolved
@petems petems force-pushed the add_description_to_workspaces branch 2 times, most recently from c745f8f to 57cedbc Compare March 6, 2021 07:58
@petems
Copy link
Contributor Author

petems commented Mar 6, 2021

@chrisarcand Added tests 🖖

Copy link
Member

@chrisarcand chrisarcand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Sorry for the delay.

tfe/data_source_workspace_test.go Outdated Show resolved Hide resolved
tfe/resource_tfe_workspace.go Outdated Show resolved Hide resolved
tfe/resource_tfe_workspace_test.go Outdated Show resolved Hide resolved
@chrisarcand chrisarcand force-pushed the add_description_to_workspaces branch from 57cedbc to e7cad75 Compare April 16, 2021 19:35
@petems petems requested a review from a team April 16, 2021 19:35
@chrisarcand chrisarcand force-pushed the add_description_to_workspaces branch from e7cad75 to 13be53f Compare April 19, 2021 20:37
@chrisarcand chrisarcand force-pushed the add_description_to_workspaces branch from 13be53f to 2cad08b Compare April 19, 2021 20:49
@chrisarcand chrisarcand merged commit aee51f2 into hashicorp:master Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants