New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add misspell task #595

Merged
merged 2 commits into from Jan 8, 2019

Conversation

Projects
None yet
3 participants
@petems
Copy link
Contributor

petems commented Dec 11, 2018

Taken from the Vault repo

@petems petems requested a review from nfagerlund Dec 11, 2018

@nfagerlund
Copy link
Collaborator

nfagerlund left a comment

👍🏼 for the szpelling corections, (hand wobbling back-and-forth) for adding the new Makefile targets. @apparentlymart ? @phinze ? Anyone else wanna weigh in?

Show resolved Hide resolved Makefile Outdated

@petems petems force-pushed the petems:add_misspell_task branch from 3da14d2 to 86cde27 Dec 12, 2018

Makefile Outdated
-v $(pwd):/scripts \
--workdir=/scripts \
nickg/misspell:latest \
misspell -error -w -source=text content/

This comment has been minimized.

@petems

petems Dec 12, 2018

Contributor

@apparentlymart @nfagerlund Changed to Docker task as requested 👍

This comment has been minimized.

@nfagerlund

nfagerlund Dec 13, 2018

Collaborator

@petems Ah ha, neat! Although... I checked it out and ran this, and it doesn't seem to do anything. :/

This comment has been minimized.

@petems

petems Dec 21, 2018

Contributor

Ah, $(pwd) doesnt work in makefiles, have to use $(CURDIR)... fixing

@petems

This comment has been minimized.

Copy link
Contributor

petems commented Dec 13, 2018

@nfagerlund

This comment has been minimized.

Copy link
Collaborator

nfagerlund commented Dec 20, 2018

@petems

╔ nick@grebe:~/Documents/terraform-website (petems/add_misspell_task ✘) ✹ 
╚ᐅ g co master
Switched to branch 'master'
Your branch is up to date with 'upstream/master'.
╔ nick@grebe:~/Documents/terraform-website (master ✔)
╚ᐅ g co petems/add_misspell_task -- Makefile
╔ nick@grebe:~/Documents/terraform-website (master ✘) ✚
╚ᐅ g st
On branch master
Your branch is up to date with 'upstream/master'.

Changes to be committed:
  (use "git reset HEAD <file>..." to unstage)

	modified:   Makefile

╔ nick@grebe:~/Documents/terraform-website (master ✘) ✚
╚ᐅ make spellcheck
==> Spell checking website and running fixes...
╔ nick@grebe:~/Documents/terraform-website (master ✘) ✚
╚ᐅ

And it didn't write changes to any files; the only reason the git status is dirty is because of the Makefile I grabbed from your branch. :/

@petems petems force-pushed the petems:add_misspell_task branch from 86cde27 to a3317c8 Dec 21, 2018

@petems

This comment has been minimized.

Copy link
Contributor

petems commented Dec 21, 2018

@nfagerlund Just pushed a fix, can you try again? 😄

@nfagerlund
Copy link
Collaborator

nfagerlund left a comment

@petems Hey, it works!!! That's pretty slick! 😄 Feel free to merge this... although you might want to wait until after the new year.

@petems

This comment has been minimized.

Copy link
Contributor

petems commented Dec 21, 2018

Yep, lets pick this up in 2019! 😄

petems added some commits Dec 11, 2018

Adds misspell task
* Quick and easy way for fixing most spelling issues

@petems petems force-pushed the petems:add_misspell_task branch from a3317c8 to 372756d Dec 21, 2018

@petems

This comment has been minimized.

Copy link
Contributor

petems commented Jan 8, 2019

Happy New Year! 😄

@petems petems merged commit 296570d into hashicorp:master Jan 8, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@petems petems deleted the petems:add_misspell_task branch Jan 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment