Better comparison of compose files #12561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested and approved! |
|
@stack72 good for you? |
|
Hi @raphink This fails the build - if you can look atthat, then we can merge Paul |
|
@stack72 Ah yes, the vendoring. I'll try and add libcompose to the PR. |
|
Fixed the deps and build is now 💚 |
|
amazing! Thanks so much :) |
stack72
pushed a commit
that referenced
this pull request
Mar 14, 2017
* Better comparison of compose files * Add github.com/docker/libcompose/config and deps to vendor
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comparing YAML files by string is not reliable. This commit interprets the compose files (using Docker's libcompose) and performs a DeepEqual comparison of the resulting structures.