Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/google: Mark GKE pass as sensitive #13148

Merged
merged 1 commit into from Mar 29, 2017
Merged

Conversation

radeksimko
Copy link
Member

Related to #13132 and #13145

Copy link
Contributor

@stack72 stack72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question as before - will this have any potential effects on users?

@radeksimko
Copy link
Member Author

As mentioned in the previous PR - it won't have any significant (meaning it doesn't break things) effect on the user as Sensitive doesn't affect whether or how is the value stored in the state. The value remains as is (plaintext). It only affects whether it's displayed in the plan or apply output.

@radeksimko radeksimko merged commit 9e7839b into master Mar 29, 2017
@radeksimko radeksimko deleted the f-google-gke-sensitive branch March 29, 2017 10:22
@ghost
Copy link

ghost commented Apr 14, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@hashicorp hashicorp locked and limited conversation to collaborators Apr 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants