Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Set aws_subnet ipv6_cidr_block to computed #14542

Merged
merged 1 commit into from May 16, 2017

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented May 16, 2017

Fixes: #14361

An IPv6 CIDR block is option and can be added after a subnet has been
created. Therefore, we should set it to Computed: true

Otherwise, a manually created IPv6 association will be removed on the
next terraform run

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSSubnet_'                      
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/05/16 17:16:15 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSSubnet_ -timeout 120m
=== RUN   TestAccAWSSubnet_importBasic
--- PASS: TestAccAWSSubnet_importBasic (54.45s)
=== RUN   TestAccAWSSubnet_basic
--- PASS: TestAccAWSSubnet_basic (51.55s)
=== RUN   TestAccAWSSubnet_ipv6
--- PASS: TestAccAWSSubnet_ipv6 (124.00s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	230.024s

Fixes: #14361

An IPv6 CIDR block is option and can be added *after* a subnet has been
created. Therefore, we should set it to `Computed: true`

Otherwise, a manually created IPv6 association will be removed on the
next terraform run
Copy link
Contributor

@grubernaut grubernaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stack72 stack72 merged commit f351de9 into master May 16, 2017
@stack72 stack72 deleted the b-aws-subnet-ipv6-cidr-computed-14361 branch May 16, 2017 14:34
@ghost
Copy link

ghost commented Apr 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@hashicorp hashicorp locked and limited conversation to collaborators Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform attempting to dissociate the ipv6_cidr_block on aws_subnet
2 participants