Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upTerraform plan reports change when there is no change to apply #1730
Comments
catsby
added
bug
provider/aws
labels
Apr 29, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
catsby
Apr 29, 2015
Member
Hey @henrikhodne – what eversion of Terraform are you using? I can't seem to reproduce this on either the latest v0.4.2 or the current master branch. If you're not on v0.4.2, can you try updating?
|
Hey @henrikhodne – what eversion of Terraform are you using? I can't seem to reproduce this on either the latest v0.4.2 or the current |
catsby
added
the
waiting-response
label
Apr 29, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
I was on 0.4.1, but I can reproduce this on 0.4.2 as well. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Interesting, I'll take another look... |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
catsby
Apr 29, 2015
Member
I've managed to reproduce this on v0.4.2, but still can't on master, so I suspect this is "resolved" in the upcoming release
|
I've managed to reproduce this on v0.4.2, but still can't on master, so I suspect this is "resolved" in the upcoming release |
catsby
removed
the
waiting-response
label
Apr 29, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
catsby
Apr 29, 2015
Member
I may be totally off but it seems that on line 91 of vpn_gateway.go, vpnGateway.AvailabilityZone has a value when I use us-east-1 (like yourself), but is nil/empty when I use us-west-2 or eu-west-1 region
|
I may be totally off but it seems that on line 91 of vpn_gateway.go, |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
catsby
Apr 29, 2015
Member
@henrikhodne can you tell if the availability zone is even actually important here? The API docs list it, but for regions beyond EAST I'm not seeing it even returned, even with the AWS CLI tool:
$ aws ec2 describe-vpn-gateways --vpn-gateway-ids vgw-eb6cb0f5
--------------------------------------------
| DescribeVpnGateways |
+------------------------------------------+
|| VpnGateways ||
|+-----------+-----------+----------------+|
|| State | Type | VpnGatewayId ||
|+-----------+-----------+----------------+|
|| available| ipsec.1 | vgw-eb6cb0f5 ||
|+-----------+-----------+----------------+|
||| Tags |||
||+------------+-------------------------+||
||| Key | Value |||
||+------------+-------------------------+||
||| Name | vpn-gateway |||
||+------------+-------------------------+||
||| VpcAttachments |||
||+---------------+----------------------+||
||| State | VpcId |||
||+---------------+----------------------+||
||| attached | vpc-74901611 |||
||+---------------+----------------------+||
$ aws ec2 describe-vpn-gateways --vpn-gateway-ids vgw-eb6cb0f5 --output=json
{
"VpnGateways": [
{
"State": "available",
"Tags": [
{
"Value": "vpn-gateway",
"Key": "Name"
}
],
"Type": "ipsec.1",
"VpnGatewayId": "vgw-eb6cb0f5",
"VpcAttachments": [
{
"State": "attached",
"VpcId": "vpc-74901611"
}
]
}
]
}For an EAST vgw:
$ AWS_DEFAULT_REGION=us-east-1 aws ec2 describe-vpn-gateways --vpn-gateway-ids vgw-8f8865e6 --output=json
{
"VpnGateways": [
{
"AvailabilityZone": "us-east-1d",
"Tags": [
{
"Value": "vpn-gateway",
"Key": "Name"
}
],
"VpcAttachments": [
{
"State": "attached",
"VpcId": "vpc-564d6033"
}
],
"State": "available",
"VpnGatewayId": "vgw-8f8865e6",
"Type": "ipsec.1"
}
]
}
|
@henrikhodne can you tell if the availability zone is even actually important here? The API docs list it, but for regions beyond EAST I'm not seeing it even returned, even with the AWS CLI tool: $ aws ec2 describe-vpn-gateways --vpn-gateway-ids vgw-eb6cb0f5
--------------------------------------------
| DescribeVpnGateways |
+------------------------------------------+
|| VpnGateways ||
|+-----------+-----------+----------------+|
|| State | Type | VpnGatewayId ||
|+-----------+-----------+----------------+|
|| available| ipsec.1 | vgw-eb6cb0f5 ||
|+-----------+-----------+----------------+|
||| Tags |||
||+------------+-------------------------+||
||| Key | Value |||
||+------------+-------------------------+||
||| Name | vpn-gateway |||
||+------------+-------------------------+||
||| VpcAttachments |||
||+---------------+----------------------+||
||| State | VpcId |||
||+---------------+----------------------+||
||| attached | vpc-74901611 |||
||+---------------+----------------------+||
$ aws ec2 describe-vpn-gateways --vpn-gateway-ids vgw-eb6cb0f5 --output=json
{
"VpnGateways": [
{
"State": "available",
"Tags": [
{
"Value": "vpn-gateway",
"Key": "Name"
}
],
"Type": "ipsec.1",
"VpnGatewayId": "vgw-eb6cb0f5",
"VpcAttachments": [
{
"State": "attached",
"VpcId": "vpc-74901611"
}
]
}
]
}For an EAST vgw:
|
catsby
added
the
waiting-response
label
May 1, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
mitchellh
Jun 27, 2015
Member
Closing due to lack of response, can't fix without it. Feel free to open a new issue with the data and we'll look back at it. Thanks!
|
Closing due to lack of response, can't fix without it. Feel free to open a new issue with the data and we'll look back at it. Thanks! |
sarahhodne commentedApr 29, 2015
We have something like this in a Terraform file:
Every time we run
terraform plan, we get a plan that looks like this:Applying doesn’t actually change anything, but we keep getting that plan. If I add
availability_zone = "us-east-1b"to the Terraform file, this step of the plan goes away.Looks like the differ doesn’t take into account that the availability zone isn’t set in the Terraform file?