Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: github.com/aws/aws-sdk-go@v1.20.10 #21908

Merged
merged 2 commits into from Jul 12, 2019

Conversation

ajayk
Copy link
Contributor

@ajayk ajayk commented Jun 27, 2019

dependency bump from github.com/aws/aws-sdk-go@v1.20.4 to github.com/aws/aws-sdk-go@v1.20.10

  • new region endpoints

References:

https://github.com/aws/aws-sdk-go/releases/tag/v1.20.10

Updated via:

$ go get github.com/aws/aws-sdk-go@v1.20.10
$ go mod tidy
$ go mod vendor

@ajayk
Copy link
Contributor Author

ajayk commented Jul 12, 2019

dependency bump from github.com/aws/aws-sdk-go@v1.20.10 to github.com/aws/aws-sdk-go@v1.20.19

https://github.com/aws/aws-sdk-go/releases

References:

https://github.com/aws/aws-sdk-go/releases/tag/v1.20.19

Updated via:

$ go get github.com/aws/aws-sdk-go@v1.20.19
$ go mod tidy
$ go mod vendor

Copy link
Member

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the second update, @ajayk. 🚀

Please note that original dependency update to v1.12.10 was not necessary as the Terraform S3 Backend does not use the AWS Go SDK regional endpoints for any information except automatic region validation when whole new regions are added. The CHANGELOG for the change contained in v1.20.19 will be this enhancement:

  • backend/s3: Support for assuming role using credential process from the shared AWS configuration file (Support profile containing both credential_process and role_arn configurations)

@bflad bflad merged commit fdbabf9 into hashicorp:master Jul 12, 2019
bflad added a commit that referenced this pull request Jul 12, 2019
@ghost
Copy link

ghost commented Aug 13, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@hashicorp hashicorp locked and limited conversation to collaborators Aug 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants