Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend/http: add support for configuration by environment variable #25439

Merged

Conversation

mattkasa
Copy link
Contributor

Hello!

This PR adds support for configuration of the http backend by environment variables, making it consistent with the majority of the other backends (artifactory, azure, consul, cos, etcdv3, gcs, kubernetes, manta, oss, s3, swift all support environment variables).

This allows for drastically cleaner CI configurations for users who use an http backend for Terraform.

A test for configuration by env has been added, and the docs have been updated to reflect the variables.

Thanks!

@hashicorp-cla
Copy link

hashicorp-cla commented Jun 30, 2020

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jun 30, 2020

Codecov Report

Merging #25439 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
backend/remote-state/http/backend.go 82.83% <100.00%> (+0.66%) ⬆️
terraform/node_resource_plan.go 91.80% <0.00%> (-1.64%) ⬇️
dag/marshal.go 53.33% <0.00%> (-1.12%) ⬇️

@nicholasklick
Copy link

This will fix #22527

@nicholasklick
Copy link

@pkolyvas Think this can move forward now?

@mildwonkey mildwonkey self-requested a review September 1, 2020 18:45
@mildwonkey mildwonkey self-assigned this Sep 1, 2020
Copy link
Contributor

@mildwonkey mildwonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great @mattkasa , thank you!

@ghost
Copy link

ghost commented Oct 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@hashicorp hashicorp locked as resolved and limited conversation to collaborators Oct 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants