core: Don't try to copy files over themselves #7273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This LGTM in principle (pending the Travis failure being fixed up)! Great catch! |
|
hmm, where did I miss the tests locally ... (oh, they're in command/) |
When copying a config module, make sure the full path for src and dst files don't match, and also check the inode in case we resolved a different path to the same file. Make a note about the unsafe usage of reusing a tempDir path.
|
Forgot to check for IsNotExist. Tests should pass now |
jbardin
added a commit
that referenced
this pull request
Jun 23, 2016
The syscall.Stat_t type doesn't exist on windows, so the inode lookup needs to be in a file with proper build constraints.
jen20
added a commit
that referenced
this pull request
Jun 24, 2016
code: Add proper build constraints for GH-7273
Closed
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When copying a config module, make sure the full path for src and dst
files don't match, and also check the inode in case we resolved a
different path to the same file.
Make a note about the unsafe usage of reusing a tempDir path.
fixes #7238