provider/aws: Add support for LB target group to ECS service #8190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
force-pushed
the
f-aws-ecs-svc-target-group
branch
from
e1966d2
to
813db96
Compare
radeksimko
force-pushed
the
f-aws-ecs-svc-target-group
branch
from
813db96
to
dd2740d
Compare
radeksimko
force-pushed
the
f-aws-ecs-svc-target-group
branch
from
c2a2f82
to
09f658c
Compare
|
Currently blocked by #8268 as ECS service pointing to an ALB target group requires such target group to have an associated ELB listener, else creation returns |
radeksimko
force-pushed
the
f-aws-ecs-svc-target-group
branch
2 times, most recently
from
303a41e
to
f08d2e6
Compare
radeksimko
changed the title
radeksimko
force-pushed
the
f-aws-ecs-svc-target-group
branch
2 times, most recently
from
3a11311
to
11297cc
Compare
radeksimko
force-pushed
the
f-aws-ecs-svc-target-group
branch
from
11297cc
to
028b94a
Compare
|
This looks delightfully complete, thanks! TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSEcsService -timeout 120m
=== RUN TestAccAWSEcsServiceWithARN
--- PASS: TestAccAWSEcsServiceWithARN (118.79s)
=== RUN TestAccAWSEcsServiceWithFamilyAndRevision
--- PASS: TestAccAWSEcsServiceWithFamilyAndRevision (109.62s)
=== RUN TestAccAWSEcsServiceWithRenamedCluster
--- PASS: TestAccAWSEcsServiceWithRenamedCluster (118.21s)
=== RUN TestAccAWSEcsService_withIamRole
--- PASS: TestAccAWSEcsService_withIamRole (124.16s)
=== RUN TestAccAWSEcsService_withDeploymentValues
--- PASS: TestAccAWSEcsService_withDeploymentValues (102.33s)
=== RUN TestAccAWSEcsService_withLbChanges
--- PASS: TestAccAWSEcsService_withLbChanges (232.95s)
=== RUN TestAccAWSEcsService_withEcsClusterName
--- PASS: TestAccAWSEcsService_withEcsClusterName (102.08s)
=== RUN TestAccAWSEcsService_withAlb
--- PASS: TestAccAWSEcsService_withAlb (129.15s)
PASS
ok github.com/hashicorp/terraform/builtin/providers/aws 1037.321s
Test: |
c4milo
added a commit
to hooklift/terraform
that referenced
this pull request
Aug 23, 2016
* master: (100 commits) Update CHANGELOG.md providers/aws: Check error from resourceAwsRoute53RecordBuildSet and return err if set (hashicorp#8399) Update CHANGELOG.md provider/aws: Add support for ECS svc - LB target group (hashicorp#8190) Added example of how the Option settings works (hashicorp#8413) Update CHANGELOG.md Update CHANGELOG.md Update CHANGELOG.md provider/aws: Add support for `network_mode` to `aws_ecs_task_definition` (hashicorp#8391) Update CHANGELOG.md Update CHANGELOG.md provider/aws: Add Primary Endpoint Address output for (hashicorp#8385) Update CHANGELOG.md provider/aws: `aws_elasticache_replication_group_id` validation change (hashicorp#8381) provider/google: Remove redundant type declaration provider/google: Hook in state migration function provider/openstack: docs and tests for allowed_address_pairs Update CHANGELOG.md website: Docs for AWS API Gateway domain name and base path mapping provider/aws: aws_api_gateway_base_path_mapping resource implementation ...
apparentlymart
pushed a commit
to hashicorp/terraform-provider-aws
that referenced
this pull request
Jul 7, 2017
Originally submitted as part of hashicorp/terraform#8190.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is WIP until we have ALB resource(s) in place.TODO
/exampleswith ECS service & ALB - may require some digging into IAMALB itself is tracked under #8137