Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
provider/vault: vault_auth_backend resource #10988
Hi @Mongey! Thanks for implementing this.
Am I understanding correctly that this is for enabling Vault auth backends? If so, I'd like to suggest to call it
One other bit of design feedback is that although by default Vault will mount a given auth backend at a path whose name matches the backend name, this is not actually required and it's possible to mount the same auth backend multiple times e.g. to support multiple different AWS accounts, or Github organizations. To support that, perhaps we could have an additional optional+computed
I didn't have time yet to dig into the code in detail or test it but I will take a look at this more deeply soon.
Thanks for the feedback @apparentlymart
Ah cool, I didn't really understand what the path arg was when I was implementing this.
Makes sense, ^ mimics the behaviour of the vault cli
changed the title from
[WIP] provider/vault: vault_auth resource
[WIP] provider/vault: vault_auth_backend resource
Jan 2, 2017
6 times, most recently
Jan 3, 2017
So I just tested this and it works as expected :) When i ran your tests, I could see my Vault log as follows:
The tests are also green:
I left 1 minor nit - but that's not worth blocking the PR over :)
Also, just a FYI, the failure in the build here is unrelated to this PR. The failure is as follows:
Merging this for now and will speak to the team about the failure