provider/aws: reading multiple pages of aws_efs_file_system tags #12328
Conversation
Fixes: #12232 ``` % make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSEFSFileSystem_pagedTags' ==> Checking that code complies with gofmt requirements... go generate $(go list ./... | grep -v /terraform/vendor/) TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSEFSFileSystem_pagedTags -timeout 120m === RUN TestAccAWSEFSFileSystem_pagedTags --- PASS: TestAccAWSEFSFileSystem_pagedTags (39.51s) PASS ok github.com/hashicorp/terraform/builtin/providers/aws 39.537s ```
| } | ||
|
|
||
| for _, tag := range tagsResp.Tags { | ||
| tags = append(tags, tag) |
There was a problem hiding this comment.
style nit: instead of a range here I believe you can just directly append, since tags is []*efs.Tag:
tags = append(tags, tagsResp.Tags...)
| tagsResp, err := conn.DescribeTags(params) | ||
| if err != nil { | ||
| return fmt.Errorf("Error retrieving EC2 tags for EFS file system (%q): %s", | ||
| d.Id(), err.Error()) |
There was a problem hiding this comment.
A thought: log the failure but break out of the for instead of returning an error. This could allow Terraform to continue creating all the things, but possibly show a diff later because there was some error in retrieving all the tags.
Just a thought, maybe you feel erring when failing to retrieve tags here is correct, so I trust/defer to your call here
| //testAccCheckEfsFileSystemPerformanceMode( | ||
| // "aws_efs_file_system.foo", | ||
| // "generalPurpose", | ||
| //), |
) Fixes: #12232 ``` % make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSEFSFileSystem_pagedTags' ==> Checking that code complies with gofmt requirements... go generate $(go list ./... | grep -v /terraform/vendor/) TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSEFSFileSystem_pagedTags -timeout 120m === RUN TestAccAWSEFSFileSystem_pagedTags --- PASS: TestAccAWSEFSFileSystem_pagedTags (39.51s) PASS ok github.com/hashicorp/terraform/builtin/providers/aws 39.537s ```
…hicorp#12328) Fixes: hashicorp#12232 ``` % make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSEFSFileSystem_pagedTags' ==> Checking that code complies with gofmt requirements... go generate $(go list ./... | grep -v /terraform/vendor/) TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSEFSFileSystem_pagedTags -timeout 120m === RUN TestAccAWSEFSFileSystem_pagedTags --- PASS: TestAccAWSEFSFileSystem_pagedTags (39.51s) PASS ok github.com/hashicorp/terraform/builtin/providers/aws 39.537s ```
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Fixes: #12232