Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detection of Artifactory repo and subpath through the environment #18824

Open
wants to merge 4 commits into
base: master
from
Commits on Sep 9, 2018
  1. Fix formatting of some files

    Hugo Torres
    Hugo Torres committed Sep 9, 2018
    `make` was failing because some of these files weren't correctly
    formatted.
    
    This commit is just for these formatting changes. This will isolate them
    to this commit so the changes to the actual logic are easier to see.
  2. Allow full Artifactory configuration from env

    Hugo Torres
    Hugo Torres committed Sep 9, 2018
    Up until now there have only been three environment variables recognized
    by Terraform for configuring Artifactory as a remote state backend:
    
    - `ARTIFACTORY_URL`: the remote URL where Artifactory can be found
    - `ARTIFACTORY_USERNAME`: the user to interact with Artifactory
    - `ARTIFACTORY_PASSWORD`: the password of the above user
    
    This made it impossible to rely fully on the environment for
    configuration. To make it possible to rely fully on the environment, the
    following two environment variables are recognized:
    
    - `ARTIFACTORY_REPO`: the repo to store remote state in
    - `ARTIFACTORY_SUBPATH`: the subpath to store the state in
  3. Refactor tests

    Hugo Torres
    Hugo Torres committed Sep 9, 2018
  4. Refactor Artifactory variable detection

    Hugo Torres
    Hugo Torres committed Sep 9, 2018
    Before `repo` and `subpath` were environment variables, it made sense
    to have every case repeated in the function because 40% of the time the
    code had to handle a different case. Now that all the variables are
    being handled the same way, it can be consolidated into one function.
You can’t perform that action at this time.