Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helper/schema: don't skip deprecation check during validation #22262

Merged
merged 1 commit into from Jul 30, 2019

Conversation

@mildwonkey
Copy link
Member

mildwonkey commented Jul 30, 2019

If an attribute was not wholly known, helper/schema was skipping the
validateType function which (among other things) returned deprecation
messages. This PR checks for deprecation before returning when skipping
validateType.

Fixes #22255

If an attribute was not wholly known, helper/schema was skipping the
`validateType` function which (among other things) returned deprecation
messages. This PR checks for deprecation before returning when skipping
validateType.
@mildwonkey mildwonkey requested a review from hashicorp/terraform-core Jul 30, 2019
@apparentlymart apparentlymart requested a review from hashicorp/terraform-enablement Jul 30, 2019
Copy link
Contributor

appilon left a comment

Seems reasonable to me

@teamterraform teamterraform merged commit 176f790 into master Jul 30, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@mildwonkey mildwonkey deleted the mildwonkey/b-deprecation-warnings branch Jul 30, 2019
@t3mi

This comment has been minimized.

Copy link

t3mi commented Aug 2, 2019

Sorry guys but the bug still exists in 0.12.6. Please check.

@jbardin

This comment has been minimized.

Copy link
Member

jbardin commented Aug 2, 2019

Hi @t3mi,

This is a change to the provider sdk, not to the terraform cli, so it will require a new release from the providers that require it.

@t3mi

This comment has been minimized.

Copy link

t3mi commented Aug 2, 2019

@jbardin thank you for clarification. Will wait for the provider release then.

@hashibot

This comment has been minimized.

Copy link

hashibot bot commented Aug 30, 2019

I'm going to lock this issue because it has been closed for 30 days . This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@hashibot hashibot bot locked and limited conversation to collaborators Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.