Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Bugfix for #23004 #23057
@mildwonkey further to my update yesterday, I found Tim's code and I saw how he was testing on Windows and set it all up and it's tested now on Windows. But the logic to provide feedback if password is absent didn't achieve anything. In fact, if password is empty, the Windows agent node hangs forever by the looks of it and never reaches my patch code--or maybe it eventually provides feedback after a 15 minute timeout. I wasn't patient enough to wait! Suffice to say I think error handling is needed somewhere to detect early that a user missed the password but it shouldn't be implemented in my bugfix.
Whenever you and Tim are happy, I'm ok for you to merge this.
I'm going to lock this issue because it has been closed for 30 days
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.