Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFail silently when account validation fails while from instance profile #3001
Conversation
radeksimko
added
bug
provider/aws
labels
Aug 14, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
bobtfish
Aug 14, 2015
Contributor
|
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
apparentlymart
Aug 16, 2015
Contributor
The logic seems reasonable.
It'd be awesome if you could run your code through go fmt to make it conform to the code style used elsewhere in Terraform.
|
The logic seems reasonable. It'd be awesome if you could run your code through |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
thanks @apparentlymart . Done |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
LGTM |
added a commit
that referenced
this pull request
Sep 8, 2015
phinze
merged commit 8559b02
into
hashicorp:master
Sep 8, 2015
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
This was referenced Sep 23, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
sarguru commentedAug 14, 2015
As far as I know, cross account IAM instance profiles are not possible, so when iam.GetUser() fails for non-User credentials , its better that it fails silently and prints the warning instead of halting the entire run.
This is similar to #2959. If there are better ways of handling (or if its better to explicitly specify) this that would be great aws well. Thanks !