Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upprovider/aws: fix for https://github.com/aws/aws-sdk-go/issues/452 #4024
Conversation
jen20
reviewed
Nov 24, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
jen20
Nov 24, 2015
Contributor
Hi @rjeczalik! Thanks for submitting this - I agree the change looks correct as per aws/aws-sdk-go#452. I've left a few comments in line on the diffs, could you let me you know what you think?
|
Hi @rjeczalik! Thanks for submitting this - I agree the change looks correct as per aws/aws-sdk-go#452. I've left a few comments in line on the diffs, could you let me you know what you think? |
jen20
added
bug
provider/aws
labels
Nov 24, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
@jen20 Addressed, please take a look. |
added a commit
that referenced
this pull request
Nov 24, 2015
jen20
merged commit 288e568
into
hashicorp:master
Nov 24, 2015
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
jen20
Nov 24, 2015
Contributor
Thanks @rjeczalik! I think this may address several crash reports, including #4036.
|
Thanks @rjeczalik! I think this may address several crash reports, including #4036. |
rjeczalik
deleted the
rjeczalik:nil-deref-fix
branch
Nov 24, 2015
This was referenced Nov 24, 2015
jen20
referenced this pull request
Nov 25, 2015
Closed
Terraform crash 0.6.7 using aws modules #4064
stevendborrelli
referenced this pull request
Nov 25, 2015
Closed
Possible issues with terraform 0.6.7 #869
bbasata
referenced this pull request
Dec 12, 2015
Closed
vault v0.4.0: runtime error with aws-sdk-go #836
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
rjeczalik commentedNov 23, 2015
Fixes nil deref panic caused by aws/aws-sdk-go#452.