Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
provider/aws: Add aws_s3_bucket_policy resource #8615
This commit adds a new "attachment" style resource for setting the policy of an AWS S3 bucket. This is desirable such that the ARN of the bucket can be referenced in an IAM Policy Document.
In addition, we now suppress diffs on the (now-computed) policy in the S3 bucket for structurally equivalent policies, which prevents flapping because of whitespace and map ordering changes made by the S3 endpoint.
I think over time (once we have more confidence in effectiveness across a wider range of policy types) we should bring it to be a helper library in the AWS provider. For now I think it's better to keep it vendored so it can be worked on separately without risking regression in Terraform?
Sep 2, 2016
1 check passed
referenced this pull request
Sep 3, 2016
This was referenced
Sep 3, 2016
@mitchellh the change here that introduces
Either the test or the ReadFunc needs to be updated, I haven't looked into this yet.