New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Command: vagrant rebuild #5378

Closed
gwagner opened this Issue Feb 23, 2015 · 13 comments

Comments

Projects
None yet
7 participants
@gwagner

gwagner commented Feb 23, 2015

Right now i have an alias to vagrant destroy --force && vagrant up for machines that i want to tear all the way down and stand back up. It would be nice if there was a vagrant rebuild command that can optionally take --force or a machine name (in a multi machine environment) that would destroy and up a machine in a single command.

@mitchellh

This comment has been minimized.

Show comment
Hide comment
@mitchellh

mitchellh Feb 24, 2015

Member

I'm open to this idea, but I wonder if it makes more sense as a vagrant reload flag, such as vagrant reload --destroy?

/cc @sethvargo

Member

mitchellh commented Feb 24, 2015

I'm open to this idea, but I wonder if it makes more sense as a vagrant reload flag, such as vagrant reload --destroy?

/cc @sethvargo

@sethvargo

This comment has been minimized.

Show comment
Hide comment
@sethvargo

sethvargo Feb 24, 2015

Contributor

I've admittedly thought about this a few times, to the point where I have a bash alias that does it. I named it vnuke and it runs destroy + up.

I personally like adding a --destroy flag to reload, since I think it maps nicely to existing UXes.

Contributor

sethvargo commented Feb 24, 2015

I've admittedly thought about this a few times, to the point where I have a bash alias that does it. I named it vnuke and it runs destroy + up.

I personally like adding a --destroy flag to reload, since I think it maps nicely to existing UXes.

@gwagner

This comment has been minimized.

Show comment
Hide comment
@gwagner

gwagner Feb 27, 2015

vagrant reload --destroy would work well, except i think --destroy is the wrong word to use.

vagrant reload --full may be a little less confusing?

gwagner commented Feb 27, 2015

vagrant reload --destroy would work well, except i think --destroy is the wrong word to use.

vagrant reload --full may be a little less confusing?

@mitchellh

This comment has been minimized.

Show comment
Hide comment
@mitchellh

mitchellh Feb 27, 2015

Member

@gwagner I think --destroy is the right word because we need to convey that we will destroy your machine and therefore all data (on the machine) will be lost. I don't want someone accidentally doing this...

Member

mitchellh commented Feb 27, 2015

@gwagner I think --destroy is the right word because we need to convey that we will destroy your machine and therefore all data (on the machine) will be lost. I don't want someone accidentally doing this...

@ggiamarchi

This comment has been minimized.

Show comment
Hide comment
@ggiamarchi

ggiamarchi Mar 2, 2015

I arrive after the PR, sorry about that. I think using the reload command to destroy a machine and recreate it can be very confusing, even with an explicit option like --destroy.

Why about introduce a new command vagrant rebuild ?

ggiamarchi commented Mar 2, 2015

I arrive after the PR, sorry about that. I think using the reload command to destroy a machine and recreate it can be very confusing, even with an explicit option like --destroy.

Why about introduce a new command vagrant rebuild ?

@gwagner

This comment has been minimized.

Show comment
Hide comment
@gwagner

gwagner Mar 2, 2015

@mitchellh based on that explanation, i agree with your point completely!

gwagner commented Mar 2, 2015

@mitchellh based on that explanation, i agree with your point completely!

@fgrehm

This comment has been minimized.

Show comment
Hide comment
@fgrehm

fgrehm Mar 3, 2015

Collaborator

Any thoughts on having it as a separate command, allowing for additional customization (like rebooting with a different provider)?

I experimented with that on https://github.com/fgrehm/vagrant-pristine and would be more than happy to submit a PR bringing that functionality into core 😄

Collaborator

fgrehm commented Mar 3, 2015

Any thoughts on having it as a separate command, allowing for additional customization (like rebooting with a different provider)?

I experimented with that on https://github.com/fgrehm/vagrant-pristine and would be more than happy to submit a PR bringing that functionality into core 😄

@berendt

This comment has been minimized.

Show comment
Hide comment
@berendt

berendt Mar 24, 2015

Contributor

At the moment the reload command is used to apply modifications in the Vagrantfile to an already running box. From my POV a --destroy option does not makes sense for the reload command. It is not longer a reload when we first destroy the instance. I think introducing a new command rebuild is the better way.

Contributor

berendt commented Mar 24, 2015

At the moment the reload command is used to apply modifications in the Vagrantfile to an already running box. From my POV a --destroy option does not makes sense for the reload command. It is not longer a reload when we first destroy the instance. I think introducing a new command rebuild is the better way.

@sethvargo

This comment has been minimized.

Show comment
Hide comment
@sethvargo

sethvargo Mar 24, 2015

Contributor

@fgrehm that looks very interesting to me 😄. I think that behavior and UX is what we are looking for here. pristine is also an interesting choice since it echos with gem pristine. I like it!

Contributor

sethvargo commented Mar 24, 2015

@fgrehm that looks very interesting to me 😄. I think that behavior and UX is what we are looking for here. pristine is also an interesting choice since it echos with gem pristine. I like it!

@berendt

This comment has been minimized.

Show comment
Hide comment
@berendt

berendt Mar 27, 2015

Contributor

@fgrehm Do you want to bring up a PR to propose to add vagrant-pristine to core?

Contributor

berendt commented Mar 27, 2015

@fgrehm Do you want to bring up a PR to propose to add vagrant-pristine to core?

@fgrehm

This comment has been minimized.

Show comment
Hide comment
@fgrehm

fgrehm Mar 30, 2015

Collaborator

Yup, hopefully at some point this week!

Collaborator

fgrehm commented Mar 30, 2015

Yup, hopefully at some point this week!

@sethvargo sethvargo added this to the 1.8 milestone Jul 10, 2015

@kcormier

This comment has been minimized.

Show comment
Hide comment
@kcormier

kcormier Jul 22, 2015

Hey Guys,

We took a quick stab at getting a rebuild command working before we noticed this pull request. We were able to reuse most of the up/down commands. Didn't know if any of this might prove useful to you guys.

https://github.com/simplisafe/vagrant-rebuild

kcormier commented Jul 22, 2015

Hey Guys,

We took a quick stab at getting a rebuild command working before we noticed this pull request. We were able to reuse most of the up/down commands. Didn't know if any of this might prove useful to you guys.

https://github.com/simplisafe/vagrant-rebuild

@sethvargo

This comment has been minimized.

Show comment
Hide comment
@sethvargo

sethvargo Nov 20, 2015

Contributor

Will be fixed by #5613

Contributor

sethvargo commented Nov 20, 2015

Will be fixed by #5613

@sethvargo sethvargo closed this Nov 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment