Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible_local: Add `cap` bug fixes and related RSpec coverage #11227

Open
wants to merge 5 commits into
base: master
from

Conversation

@gildegoma
Copy link
Collaborator

gildegoma commented Dec 1, 2019

馃毀 not ready for review yet 馃毀

Includes

Bug Fixes:

  • Review of #11148 (ArchLinux bug fix)
  • Fix method signature for FreeBSD and SuSE

Improvements:

  • Trim the generated 'pip install' command in Ansible::Cap::Guest::Pip::pip_install

RSpec Coverage:

  • ArchLinux Guest
  • Debian Guest
  • Ubuntu Guest
  • FreeBSD Guest
  • SuSE Guest
  • Fedora Guest
  • RedHat/CentOS Guest

Integration Tests:

  • archlinux/archlinux -> caught 909cc20
  • freebsd/FreeBSD-12.1-RELEASE
  • SuSE

References

skoenen and others added 5 commits Oct 23, 2019
鈥r arch guest.

ADD: Handling of `pip_install_cmd` in `ansible_install.rb` for arch guest.
There is no such thing like 'pip_install_command' option in the
Ansible Local provision, so let's avoid any misunderstanding ;-)
- By the way: Trim the generate 'pip install' command in Ansible::Cap::Guest::Pip::pip_install
- GH-11048: Fix same regression for FreeBSD and SuSE guests.
- GH-6633:  Add RSpec examples to cover ansible_local 'cap' code.

Note: RedHat/Fedora guests are not covered yet by unit tests.
GH-11148: Remove unwanted formatting changes proposed in 9203611.
Add 'python' package requirement. Tested against `archlinux/archlinux`
box, at version "2019.11.24".
@gildegoma

This comment has been minimized.

Copy link
Collaborator Author

gildegoma commented Dec 1, 2019

@briancain I wanted to create this PR as a Draft pull request (but missed to select it when clicking on the create button). I don't find a way to switch it to draft... so I'll let you know when it is ready for review via a thread comment (aka the old way).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.