Fix SSH communicator connections for rsa keys #12298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifies `OpenSSL::PKey::RSA` to provide a `#signature_algorithm`
method which provides the signature algorithm value expected by
OpenSSH. The `#ssh_do_sign` method is updated to use the set
algorithm (SHA256) and `#to_blob` is updated to include the
signature algorithm instead of the key type.
chrisroberts
force-pushed
the
fix-rsa-ssh
branch
from
e896fa2
to
af54aea
Compare
chrisroberts
force-pushed
the
fix-rsa-ssh
branch
from
af54aea
to
be00516
Compare
Keep the constraint on net-ssh tight so we can be confident that the
patching will be successful and that a net-ssh release won't inadvertently
cause our local updates to become non-functional.
Fix patch to only update the behavior for RSA based keys when the server
is recent enough to include the signature changes
chrisroberts
force-pushed
the
fix-rsa-ssh
branch
from
be00516
to
a08597d
Compare
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue introduced from updates to OpenSSH which modifies
the expectations on a user authentication request wanting the signature
algorithm being used and no longer the name of the key type.
Fixes #11783