New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix #1108, #1109, tcp and udp port on the same port number #1260

Merged
merged 1 commit into from Jan 4, 2013

Conversation

Projects
None yet
2 participants
@hdorio
Contributor

hdorio commented Dec 12, 2012

when forwarded ports are squashed, if a tcp and udp port share the same port number one of them is forgotten

fixes tcp and udp on the same port number GH-1108, GH-1109
fix a bug in forward_port_definitions() in Action::ForwardPorts
@mitchellh

This comment has been minimized.

Show comment
Hide comment
@mitchellh

mitchellh Jan 4, 2013

Member

Looks good to me. Thanks :) Merged.

Member

mitchellh commented Jan 4, 2013

Looks good to me. Thanks :) Merged.

mitchellh added a commit that referenced this pull request Jan 4, 2013

Merge pull request #1260 from hdorio/master
Attempt to fix #1108, #1109, tcp and udp port on the same port number

@mitchellh mitchellh merged commit a489629 into hashicorp:master Jan 4, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment