Multivm hostname #1280

wants to merge 54 commits into


None yet

kbrock commented Dec 29, 2012


When in a multi vm environment, all vms have the same name in virtualbox. This makes it tricky to know which machine is which.

This patch uses the vm's host_name if it is available.

A) This is based upon the 1.0 branch, since that is what I use. Please point me to the 1.1 (master) vs 1.0 (stable) branching strategy FAQ and I can rebase.

B) If you have an example of an action tested / and how much you want to mock out, please let me know. (I saw some good legacy tests that used the environment)

C) Also, I noticed that Environment#root_path is documented to return a String, but the existing code assumes a Pathname is coming out.This threw a wrench into my testing, so please advise and I can fix this as well.

Thanks for the great tool,

jhf and others added some commits Apr 30, 2012

Fixes a bug where interfaces are assigned in a wrong order when using…
… ruby1.8, causing vm boot to stop as documented in issue #898
Merge pull request #951 from oker1/preserve
Preserve attritubes on included files
Revert "preserve attributes on packaging when using ruby 1.9.2"
This reverts commit 9c038c7.

I didn't mean to backport this.
Merge pull request #966 from pmorton/read_mac_addresses
Add the ability to map mac addresses to interfaces
Use instead of localhost for port use checking. [GH-1057]
Many systems actually don't have "localhost" setup as loopback in their
/etc/hosts file, so this would fail. This makes it pass.
Added driver for VirtualBox 4.2 to 1.0.x stable this is so far not ve…
…ry deep tested. but vagrant up and base commands to work.
Merge pull request #1120 from julianhille/1-0-stable
Added driver for VirtualBox 4.2 to 1.0.x stable this is so far not very...
Merge pull request #1128 from sbfaulkner/1-0-stable
backport Windows fix onto 1-0-stable
Fix arch host class
1. Detect os by /etc/os-release
2. Bring nfs_cleanup from parent class
3. Use systemd if available
Remove #nfs? override
My system is now showing nfsd in /proc/filesystems. It must've been
some transient hiccup local to me.
Work around 4.2.0 bug on Windows
VirtualBox 4.2.0 on Windows has a critical bug where "showvminfo
--machinereadable" only outputs 5 lines of output no matter what.
Vagrant relies heavily on this output to read things such as network
interfaces, shared folders, etc. Therefore, prior to this commit,
Vagrant was broken on Windows. Note that this is 100% a VIRTUALBOX BUG.
But enough users will use VirtualBox 4.2.0 on Windows that Vagrant must
work around it.

We work around it by introducing "jank mode" for the 4.2 driver on
Windows. On 4.2.0 only on Windows, Vagrant will use the human-readable
version of "showvminfo" and use some pretty crazy regular expressions to
parse out the information it needs. This approach is far less tested but
it at least gets things working again on Windows with 4.2.0. I'm hoping
in the future that Oracle will quickly fix this issue for a 4.2.1, but
I'm not certain yet.

Even if Oracle fixes the issue, this workaround will be in Vagrant
forever to accomodate legacy 4.2.0 users on Windows.
Merge pull request #1142 from pbrisbin/arch-fix-2
Fix arch host class to work with systemd changes

Thanks for your efficiency!

Peter Eisentraut and others added some commits Oct 8, 2012

Check exit codes of puppet provisioners
Previously, failures in applying the puppet manifests would be
ignored, because puppet apply/agent don't have any useful exit codes
by default.  (Errors are printed, but vagrant continues.)

Use the option --detailed-exitcodes of puppet apply/agent to check for
Merge pull request #1182 from obscurerichard/fix-windows-shell-provis…

Fix Windows shell provisioning
Merge pull request #1180 from maestrodev/v1.0.5-exitcodes
Check exit codes of puppet provisioners
Work around bug in OS X 10.8 and VirtualBox wrt VBoxManage
OS X 10.8 introduced a bug where on setuid/setgid executables, it will
print a warning to stdout if any DYLD_ enviornmental variables are set
(most common being DYLD_LIBRARY_PATH).

VirtualBox, specifically VBoxManage, sometimes shells out to external
programs to do some work, reading stdout for the result. The warnings
injected by OS X cause VirtualBox to read bad values, breaking Vagrant.

These work around both of these issues. Great.

This version is currently not pushed to


mitchellh replied Jan 25, 2013

@spider-network It is now! Sorry about that.

kbrock commented Dec 29, 2012

oops - wrong branch

@kbrock kbrock closed this Dec 29, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment