Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAllow user to define if the box_url is insecure #1712
Conversation
This comment has been minimized.
This comment has been minimized.
Hey @mitchellh, looks like you fixed this on af66f5f, shall we close this? |
This comment has been minimized.
This comment has been minimized.
Oh I did, yep. Closing! Thanks. |
This comment has been minimized.
This comment has been minimized.
@mitchellh @sethvargo Since it is a terrible practice to disable SSL verification long term, would it be possible to add instructions on correcting the certificate issue the right way by catching this certificate error exception and giving a helpful suggestion, i.e. adding the certificate to the trust chain of the embedded Ruby and curl or better yet using the alternate CA path that was added to a newer Vagrant version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
igorbonadio commentedMay 10, 2013
Currently, it's possible to download a box from an insecure server using the command:
But I think set it in a Vagrantfile is a good feature.