New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins loaded hook #2437

Merged
merged 2 commits into from Nov 24, 2013

Conversation

Projects
None yet
2 participants
@fgrehm
Collaborator

fgrehm commented Oct 29, 2013

As I just wrote on the mailing list about a potential "vagrant-dotenv" plugin and based on what we had to do on Bindler I propose that we add a new hook to Environment that gets triggered after loading plugins but prior to loading Vagrantfiles.

This will allow plugin developers to do all sorts of "magic" before configurations from Vagrantfiles are parsed. The current :environment_load hook ends up parsing the Vagrantfiles and we can't use that.

I hope that's enough information for this to get merged but I'd be fine to provide use cases if needed :D

@mitchellh

This comment has been minimized.

Show comment
Hide comment
@mitchellh

mitchellh Nov 24, 2013

Member

Agreed. Thanks Fabio!

Member

mitchellh commented Nov 24, 2013

Agreed. Thanks Fabio!

mitchellh added a commit that referenced this pull request Nov 24, 2013

Merge pull request #2437 from fgrehm/plugins-loaded-hook
core: plugins loaded hook with no vagrantfiles

@mitchellh mitchellh merged commit 1ea39ab into hashicorp:master Nov 24, 2013

1 check failed

default The Travis CI build failed
Details

@fgrehm fgrehm deleted the fgrehm:plugins-loaded-hook branch Nov 25, 2013

@fgrehm fgrehm referenced this pull request Nov 25, 2013

Closed

Remove some monkey patching #23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment