New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Fedora 20 network issues when virtual #4297

Merged
merged 1 commit into from Aug 6, 2014

Conversation

Projects
None yet
2 participants
@gildub
Contributor

gildub commented Aug 5, 2014

On Fedora 20 virtual machines biosdevname command
'Returns 4 if running in a virtual machine.'

This patch:

  • Uses the biosdevname command return value to detect if virtual
  • Uses /sys/net to get interface names - Might be better solution
  • Leaves unchanged the original 'bare metal' case - I wonder what for
    though?

Tested with Fedora Cloud image adapted for vagrant-libvirt

Fixes issue #4104

Fixes Fedora 20 network issues when virtual
On Fedora 20 virtual machines biosdevname command
'Returns 4 if running in a virtual machine.'

This patch:
  - Uses the biosdevname command return value to detect if virtual
  - Uses /sys/net to get interface names - Might be better solution
  - Leaves unchanged the original 'bare metal' case - I wonder what for
    though?

Tested with Fedora Cloud image adapted for vagrant-libvirt

Fixes issue #4104
@mitchellh

This comment has been minimized.

Show comment
Hide comment
@mitchellh

mitchellh Aug 6, 2014

Member

This looks like a great solution. Thank you!

Member

mitchellh commented Aug 6, 2014

This looks like a great solution. Thank you!

mitchellh added a commit that referenced this pull request Aug 6, 2014

Merge pull request #4297 from gildub/bug/fedora20+network
guests/fedora: Fixes Fedora 20 network issues when virtual

@mitchellh mitchellh merged commit 1cafc00 into hashicorp:master Aug 6, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment