Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't do the port threshold check if running under root #487

Closed
wants to merge 1 commit into from
Closed

Don't do the port threshold check if running under root #487

wants to merge 1 commit into from

Conversation

samerbuna
Copy link

For the rare case where a risk-taker wants to run the machine under root (and thus have access to ports under 1024), allow them.

It's fairly important in our setup that we forward ports 80 and 443 to vagrant, running the machine under root is an acceptable compromise.

@mitchellh mitchellh closed this in 7219f3d Sep 12, 2011
@mitchellh
Copy link
Contributor

I merged in your pull request and also made a slight modification:

Its not safe to simply check for "root" in the ENV["USER"], since this won't work on Windows and won't work in some shells since the "USER" env var might not be sent. In the end, I concluded there is no safe way to check this (that I know of), so instead of prohibiting it, I simply issue a warning.

This would be fine :)

@hashicorp hashicorp locked and limited conversation to collaborators Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants