Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use SafeExec to capture history via up/down keys in powershell command #6749

Merged
merged 1 commit into from Feb 3, 2016

Conversation

Projects
None yet
3 participants
@mwrock
Copy link
Contributor

mwrock commented Dec 27, 2015

Subprocess sets up the process in such a way that pressing the up/down arrows does not cycle through command history in the powershell command. Using SafeExec instead as the ssh command does seems to fix this.

@sethvargo sethvargo modified the milestones: 1.8.1, 1.8.2 Dec 28, 2015

@mwrock

This comment has been minimized.

Copy link
Contributor Author

mwrock commented Jan 18, 2016

Any chance of getting this into 1.8.2 @sethvargo ? Been using it consistently without issue on a couple machines.

sethvargo pushed a commit that referenced this pull request Feb 3, 2016

Seth Vargo
Merge pull request #6749 from mwrock/hist
use SafeExec to capture history via up/down keys in powershell command

@sethvargo sethvargo merged commit 2ce3c84 into hashicorp:master Feb 3, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mkuzmin

This comment has been minimized.

Copy link
Contributor

mkuzmin commented May 19, 2016

Hi Matt

I applied this change on top of my 1.8.1 installation, but see no difference. Are there any other requirements?

@mwrock

This comment has been minimized.

Copy link
Contributor Author

mwrock commented May 19, 2016

Hmm. I refreshed my vagrant install from master a couple days ago and I do see the improved behavior. I'm on a windows 10 host. Its possible other hosts might behave differently but its not really easy for me to try on a different host.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.