/vagrant

Fixes 7073 specification.rb undefined method group by for nilclass #7198

Closed
wants to merge 1 commit into
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
9 participants
@kamigerami @sethvargo @terceiro @jwmatthews @dustymabe @haisum @praveenkumar @developerinlondon @zeha
@kamigerami
Contributor

kamigerami commented Apr 2, 2016

Adding PR for #7073 - As discussed in https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=818237 and suggested by @babilen ...

my bundle exec rake tests are failing locally however I am adding this as a PR to have the Travis CI tests run to make sure whether everything is fine or not. Feel free to close it or merge it depending on the output of the tests.
@sethvargo
Contributor

sethvargo commented Apr 2, 2016

Hi @kamigerami

Could you please rebase with master?
@kamigerami
Contributor

kamigerami commented Apr 3, 2016

Hi @sethvargo. For sure! 😎 👍
@terceiro
Contributor

terceiro commented Apr 3, 2016

you should probably credit the original author of the solution as the author of the commit ...
@kamigerami
Contributor

kamigerami commented Apr 3, 2016

Absolutely @terceiro ! Crediting Christian Hofstaedtler as the author of this solution as mentioned in the first comment made in this PR (see url link from original discussion in bugs.debian.org)
@terceiro
Contributor

terceiro commented Apr 3, 2016

I mean the commit itself should have him as the author ...
@kamigerami
Contributor

kamigerami commented Apr 17, 2016

@sethvargo @terceiro @zeha updated with original author as the author of the commit.

Thank you all!
@jwmatthews

jwmatthews commented Apr 21, 2016

@kamigerami this PR doesn't look right, seems like you only need 1 commit, but you have ~24 in it. Perhaps you need to rebase against master, or re-open this PR with the single commit you intended.

Looking forward to seeing this merged in, as I'm seeing similar issues with vagrant in Fedora 24 alpha that this 1line fix resolved.

kamigerami added a commit to kamigerami/vagrant that referenced this pull request Apr 21, 2016

@zeha @kamigerami
fixes-#7073-specification.rb-undefined-method-group_by-for-nilclass: PR 
#7198 allows vagrant to work with newer versions of various ruby libs by explicitly calling reset
This commit was signed with a verified signature.
@kamigerami kamigerami Kami Gerami
GPG key ID: F1C36FD57C59CB03 Learn about signing commits
fb5f295
@kamigerami
Contributor

kamigerami commented Apr 21, 2016

@jwmatthews thnx for pointing that out! Should be good now!

asomers referenced this pull request in rubygems/rubygems Apr 25, 2016

@segiddins
[Specification] Also reset specs_by_name when setting all
044b0e2

@dustymabe dustymabe referenced this pull request Apr 25, 2016

Closed

Cannot install plugin: undefined method `group_by' for nil:NilClass #6911

@dustymabe
Contributor

dustymabe commented Apr 25, 2016

I'll second that this patch enabled things to work on Fedora 24 alpha.
@jwmatthews

jwmatthews commented Apr 26, 2016

@kamigerami looks good, hope this gets merged in.
@haisum

haisum commented Apr 26, 2016

How do I fix it in my Ubuntu 16.04 right now temporarily, instead of waiting for this to get merged and new package update?
@haisum

haisum commented Apr 26, 2016

I found it, posting for other's reference. Said file is located at /usr/lib/ruby/vendor_ruby/vagrant/bundler.rb replace line 275 with Gem::Specification.reset it will fix the issue.
@praveenkumar

praveenkumar commented Apr 29, 2016

I tested this patch with fedora24 alpha and it did work, hope this gets merged in now.

@armab armab referenced this pull request May 2, 2016

Closed

specification.rb:945:in `all=': undefined method `group_by' for nil:NilClass (NoMethodError) #7073

kamigerami added a commit to kamigerami/vagrant that referenced this pull request May 6, 2016

@zeha @kamigerami
fixes-#7073-specification.rb-undefined-method-group_by-for-nilclass: PR 
#7198 allows vagrant to work with newer versions of various ruby libs by explicitly calling reset
c3648ab

kamigerami added a commit to kamigerami/vagrant that referenced this pull request May 6, 2016

@kamigerami
Merge branch 'fixes-7073-specification.rb-undefined-method-group_by-f… 
…or-nilclass' of https://github.com/kamigerami/vagrant into fixes-7073-specification.rb-undefined-method-group_by-for-nilclass

* 'fixes-7073-specification.rb-undefined-method-group_by-for-nilclass' of https://github.com/kamigerami/vagrant:
  fixes-#7073-specification.rb-undefined-method-group_by-for-nilclass: PR #7198 allows vagrant to work with newer versions of various ruby libs by explicitly calling reset
a0c3bfb

kamigerami added a commit to kamigerami/vagrant that referenced this pull request May 6, 2016

@kamigerami
Revert "fixes-#7073-specification.rb-undefined-method-group_by-for-ni… 
…lclass: PR #7198 allows vagrant to work with newer versions of various ruby libs by explicitly calling reset"

This reverts commit c3648ab.
88ef856

kamigerami added a commit to kamigerami/vagrant that referenced this pull request May 6, 2016

@kamigerami
Revert "Revert "fixes-#7073-specification.rb-undefined-method-group_b… 
…y-for-nilclass: PR #7198 allows vagrant to work with newer versions of various ruby libs by explicitly calling reset""

This reverts commit 88ef856.
569403a
@zeha @kamigerami
fixes-#7073-specification.rb-undefined-method-group_by-for-nilclass: PR 
#7198 allows vagrant to work with newer versions of various ruby libs by explicitly calling reset
82e88be
@developerinlondon

developerinlondon commented May 11, 2016

when is this getting released? The current version of Vagrant does not work with Ubuntu 16.04 when we try to install vagrant plugins (eg vagrant lxc, vagrant hostmanager etc). This would be very useful as we are currently having to hack vagrant to get this to work.
@sethvargo
Contributor

sethvargo commented May 27, 2016

Merged in ba77d4b

@sethvargo sethvargo closed this May 27, 2016

@onibox onibox referenced this pull request in emyl/vagrant-triggers Dec 8, 2016

Closed

Support for Ubuntu 16.04 LTS #78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment