New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for #7610 (incorrect permissions on ~/.ssh/authorized_keys causes authentication failure after insecure keypair replacement) #7611

Merged
merged 3 commits into from Jul 20, 2016

Conversation

Projects
None yet
5 participants
@Poohblah
Contributor

Poohblah commented Jul 19, 2016

This fixes the issue reported in #7610. I'm not sure if any additional test cases are necessary to cover this; I can certainly write some if they are.

@Poohblah Poohblah changed the title from fix for #7610 (incorrect permissions on ~/.ssh/authorized_keys causes insecure keypair replacement failure) to fix for #7610 (incorrect permissions on ~/.ssh/authorized_keys causes authentication failure after insecure keypair replacement) Jul 19, 2016

@edestecd

This comment has been minimized.

Show comment
Hide comment
@edestecd

edestecd Jul 19, 2016

👍 I experienced the same issue on ubuntu directly after updating to 1.8.5 :(

Please insert this patch asap!

I'm on Virtualbox 5.0.26

edestecd commented Jul 19, 2016

👍 I experienced the same issue on ubuntu directly after updating to 1.8.5 :(

Please insert this patch asap!

I'm on Virtualbox 5.0.26

@Poohblah

This comment has been minimized.

Show comment
Hide comment
@Poohblah

Poohblah Jul 19, 2016

Contributor

Looks like unit tests are missing entirely for the remove_public_key method. I'll see if I can't get some written.

Contributor

Poohblah commented Jul 19, 2016

Looks like unit tests are missing entirely for the remove_public_key method. I'll see if I can't get some written.

@Poohblah

This comment has been minimized.

Show comment
Hide comment
@Poohblah

Poohblah Jul 19, 2016

Contributor

PR updated with unit tests. Also fixed a typo.

Contributor

Poohblah commented Jul 19, 2016

PR updated with unit tests. Also fixed a typo.

@sethvargo sethvargo added this to the 1.8.6 milestone Jul 19, 2016

@sethvargo sethvargo self-assigned this Jul 19, 2016

@pietervogelaar

This comment has been minimized.

Show comment
Hide comment
@pietervogelaar

pietervogelaar Jul 20, 2016

Same issue here on Mac OS X after updating to Vagrant 1.8.5. I'm on VirtualBox 5.0.26.

pietervogelaar commented Jul 20, 2016

Same issue here on Mac OS X after updating to Vagrant 1.8.5. I'm on VirtualBox 5.0.26.

@sethvargo sethvargo merged commit 2418cb1 into hashicorp:master Jul 20, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Poohblah

This comment has been minimized.

Show comment
Hide comment
@Poohblah

Poohblah Jul 20, 2016

Contributor

Thanks @sethvargo!

Contributor

Poohblah commented Jul 20, 2016

Thanks @sethvargo!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.